Verify dcl_function_body and dcl_function_table

Author: asavonic

mlir/include/mlir/Dialect/DXSA/IR/DXSAOps.td

@@ -730,7 +730,7 @@ def DXSA_DclFunctionBody : DXSA_Op<"dcl_function_body"> {
     dxsa.dcl_function_body 0
     ```
   }];
-  let arguments = (ins I32Attr:$index);
+  let arguments = (ins ConfinedAttr<I32Attr, [IntNonNegative]>:$index);
   let assemblyFormat = "$index attr-dict";
 }
 
@@ -750,8 +750,10 @@ def DXSA_DclFunctionTable : DXSA_Op<"dcl_function_table"> {
     dxsa.dcl_function_table 0, <functions = [0, 1]>
     ```
   }];
-  let arguments = (ins I32Attr:$index, DenseI32ArrayAttr:$functions);
+  let arguments = (ins ConfinedAttr<I32Attr, [IntNonNegative]>:$index,
+                       DenseI32ArrayAttr:$functions);
   let assemblyFormat = "$index `,` `<` `functions` `=` $functions `>` attr-dict";
+  let hasVerifier = 1;
 }
 
 #endif // DXSA_OPS

mlir/lib/Dialect/DXSA/IR/DXSA.cpp

@@ -41,6 +41,16 @@ void DXSADialect::initialize() {
 #define GET_OP_CLASSES
 #include "mlir/Dialect/DXSA/IR/DXSAOps.cpp.inc"
 
+LogicalResult DclFunctionTable::verify() {
+  for (int32_t functionIndex : getFunctions()) {
+    if (functionIndex < 0) {
+      return emitOpError("function body index must not be negative, got ")
+             << functionIndex;
+    }
+  }
+  return success();
+}
+
 //===----------------------------------------------------------------------===//
 // TableGen'd attribute method definitions
 //===----------------------------------------------------------------------===//

mlir/test/Target/DXSA/dcl_function_body_invalid.mlir

@@ -0,0 +1,4 @@
+// RUN: mlir-opt %s -split-input-file -verify-diagnostics
+
+// expected-error@+1 {{'dxsa.dcl_function_body' op attribute 'index' failed to satisfy constraint: 32-bit signless integer attribute whose value is non-negative}}
+dxsa.dcl_function_body -1

mlir/test/Target/DXSA/dcl_function_table_invalid.mlir

@@ -0,0 +1,9 @@
+// RUN: mlir-opt %s -split-input-file -verify-diagnostics
+
+// expected-error@+1 {{'dxsa.dcl_function_table' op attribute 'index' failed to satisfy constraint: 32-bit signless integer attribute whose value is non-negative}}
+dxsa.dcl_function_table -1, <functions = [0, 1]>
+
+// -----
+
+// expected-error@+1 {{'dxsa.dcl_function_table' op function body index must not be negative, got -1}}
+dxsa.dcl_function_table 1, <functions = [0, -1]>