Skip to content

Commit 8df5916

Browse files
chore(deps): bump hiero-ledger/hiero-solo-action from 0.18.0 to 0.19.0 (hiero-ledger#2191)
Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Manish Dait <daitmanish88@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Manish Dait <daitmanish88@gmail.com> Co-authored-by: Manish Dait <90558243+manishdait@users.noreply.github.com>
1 parent 306717b commit 8df5916

14 files changed

Lines changed: 92 additions & 40 deletions

.github/workflows/pr-check-primary-test-files.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,8 @@ jobs:
3535

3636
- name: Set up Node.js
3737
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
38+
with:
39+
node-version: '20'
3840

3941
- name: Run test file naming check
4042
run: node .github/scripts/pr-check-test-files.js

.github/workflows/pr-check-secondary-examples.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,13 @@ jobs:
3434

3535
- name: Prepare Hiero Solo
3636
id: solo
37-
uses: hiero-ledger/hiero-solo-action@692b186bd2e4c8d46b9deb1c067dc6ddcf0abcd7 #v0.15.0
37+
uses: hiero-ledger/hiero-solo-action@328bc84c3b00a990a151418144fd682a4eb76ea6 #v0.19.0
3838
with:
3939
installMirrorNode: true
40+
soloVersion: v0.65.0
41+
mirrorNodeVersion: v0.153.0
42+
hieroVersion: v0.73.0
43+
4044
- name: Run Examples
4145
env:
4246
OPERATOR_ID: ${{ steps.solo.outputs.accountId }}

.github/workflows/pr-check-secondary-unit-integration-test.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,9 +129,12 @@ jobs:
129129

130130
- name: Prepare Hiero Solo
131131
id: solo
132-
uses: hiero-ledger/hiero-solo-action@692b186bd2e4c8d46b9deb1c067dc6ddcf0abcd7 # v0.15.0
132+
uses: hiero-ledger/hiero-solo-action@328bc84c3b00a990a151418144fd682a4eb76ea6 # v0.19.0
133133
with:
134134
installMirrorNode: true
135+
soloVersion: v0.65.0
136+
mirrorNodeVersion: v0.153.0
137+
hieroVersion: v0.73.0
135138

136139
- name: Run integration tests
137140
id: integration

examples/account/account_update_transaction_with_keylist.py

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -84,16 +84,15 @@ def account_update_with_keylist():
8484
threshold_key = KeyList([threshold_key_1.public_key(), threshold_key_2.public_key()], threshold=2)
8585

8686
print("\nRotating account key to a 2-of-2 threshold KeyList...")
87-
key_list_receipt = (
88-
AccountUpdateTransaction()
89-
.set_account_id(account_id)
90-
.set_key(threshold_key)
91-
.freeze_with(client)
92-
.sign(current_private_key) # Sign with current key
93-
.sign(threshold_key_1) # First signature for threshold=2
94-
.sign(threshold_key_2) # Second signature for threshold=2
95-
.execute(client)
96-
)
87+
tx = AccountUpdateTransaction().set_account_id(account_id).set_key(threshold_key)
88+
89+
tx.transaction_fee = Hbar.from_hbars(10)
90+
91+
tx.freeze_with(client)
92+
tx.sign(current_private_key) # Sign with current key
93+
tx.sign(threshold_key_1) # First signature for threshold=2
94+
tx.sign(threshold_key_2) # Second signature for threshold=2
95+
key_list_receipt = tx.execute(client)
9796

9897
if key_list_receipt.status != ResponseCode.SUCCESS:
9998
print(f"KeyList rotation failed with status: {ResponseCode(key_list_receipt.status).name}")

examples/nodes/node_create_transaction.py

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
from dotenv import load_dotenv
2424

2525
from hiero_sdk_python import AccountId, Client, Network, PrivateKey
26+
from hiero_sdk_python.account.account_create_transaction import AccountCreateTransaction
2627
from hiero_sdk_python.address_book.endpoint import Endpoint
2728
from hiero_sdk_python.nodes.node_create_transaction import NodeCreateTransaction
2829
from hiero_sdk_python.response_code import ResponseCode
@@ -65,7 +66,13 @@ def node_create():
6566

6667
# Node account ID - this should be an existing account
6768
# that will be associated with the node
68-
account_id = AccountId.from_string("0.0.4")
69+
account_id = (
70+
AccountCreateTransaction()
71+
.set_key_without_alias(PrivateKey.generate_ecdsa())
72+
.freeze_with(client)
73+
.execute(client)
74+
.account_id
75+
)
6976

7077
# Node description
7178
description = "Example node"

examples/nodes/node_delete_transaction.py

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
from dotenv import load_dotenv
2424

2525
from hiero_sdk_python import AccountId, Client, Network, PrivateKey
26+
from hiero_sdk_python.account.account_create_transaction import AccountCreateTransaction
2627
from hiero_sdk_python.address_book.endpoint import Endpoint
2728
from hiero_sdk_python.nodes.node_create_transaction import NodeCreateTransaction
2829
from hiero_sdk_python.nodes.node_delete_transaction import NodeDeleteTransaction
@@ -64,7 +65,13 @@ def create_node(client):
6465
"""Create a node on the network and return its ID and admin key."""
6566
# Node account ID - this should be an existing account
6667
# that will be associated with the node
67-
account_id = AccountId.from_string("0.0.4")
68+
account_id = account_id = (
69+
AccountCreateTransaction()
70+
.set_key_without_alias(PrivateKey.generate_ecdsa())
71+
.freeze_with(client)
72+
.execute(client)
73+
.account_id
74+
)
6875

6976
# Node description
7077
description = "Example node for deletion"

examples/nodes/node_update_transaction.py

Lines changed: 16 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
from dotenv import load_dotenv
2424

2525
from hiero_sdk_python import AccountId, Client, Network, PrivateKey
26+
from hiero_sdk_python.account.account_create_transaction import AccountCreateTransaction
2627
from hiero_sdk_python.address_book.endpoint import Endpoint
2728
from hiero_sdk_python.nodes.node_create_transaction import NodeCreateTransaction
2829
from hiero_sdk_python.nodes.node_update_transaction import NodeUpdateTransaction
@@ -60,12 +61,8 @@ def setup_client():
6061
return client
6162

6263

63-
def create_node(client):
64+
def create_node(client, account_id):
6465
"""Create a node on the network and return its ID and admin key."""
65-
# Node account ID - this should be an existing account
66-
# that will be associated with the node
67-
account_id = AccountId.from_string("0.0.4")
68-
6966
# Node description
7067
description = "Example node"
7168

@@ -108,11 +105,8 @@ def create_node(client):
108105
return receipt.node_id, admin_key
109106

110107

111-
def update_node(client, node_id, admin_key):
108+
def update_node(client, account_id, node_account_key, node_id, admin_key):
112109
"""Update an existing node with new parameters."""
113-
# Node account ID
114-
account_id = AccountId.from_string("0.0.4")
115-
116110
# Updated node description
117111
updated_description = "Updated example node"
118112

@@ -139,7 +133,8 @@ def update_node(client, node_id, admin_key):
139133
.set_grpc_web_proxy_endpoint(updated_grpc_proxy_endpoint)
140134
.set_decline_reward(False)
141135
.freeze_with(client)
142-
.sign(admin_key) # Sign with the admin key
136+
.sign(admin_key)
137+
.sign(node_account_key)
143138
.execute(client)
144139
)
145140

@@ -163,11 +158,20 @@ def node_update():
163158
# Set up client with operator account
164159
client = setup_client()
165160

161+
node_account_private_key = PrivateKey.generate_ecdsa()
162+
node_account_id = (
163+
AccountCreateTransaction()
164+
.set_key_without_alias(node_account_private_key)
165+
.freeze_with(client)
166+
.execute(client)
167+
.account_id
168+
)
169+
166170
# Create a new node and get its ID and admin key
167-
node_id, admin_key = create_node(client)
171+
node_id, admin_key = create_node(client, node_account_id)
168172

169173
# Update the newly created node with modified parameters
170-
update_node(client, node_id, admin_key)
174+
update_node(client, node_account_id, node_account_private_key, node_id, admin_key)
171175

172176
print("\nNode creation and update example completed successfully!")
173177

tests/integration/account_update_transaction_e2e_test.py

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -92,15 +92,15 @@ def test_integration_account_update_transaction_set_key_with_threshold_keylist(e
9292
key_2_private = PrivateKey.generate_ed25519()
9393
threshold_key = KeyList([key_1_private.public_key(), key_2_private.public_key()], threshold=2)
9494

95-
receipt = (
96-
AccountUpdateTransaction()
97-
.set_account_id(account_id)
98-
.set_key(threshold_key)
99-
.freeze_with(env.client)
100-
.sign(key_1_private)
101-
.sign(key_2_private)
102-
.execute(env.client)
103-
)
95+
tx = AccountUpdateTransaction().set_account_id(account_id).set_key(threshold_key)
96+
97+
tx.transaction_fee = Hbar.from_hbars(5)
98+
tx.freeze_with(env.client)
99+
tx.sign(key_1_private)
100+
tx.sign(key_2_private)
101+
102+
receipt = tx.execute(env.client)
103+
104104
assert receipt.status == ResponseCode.SUCCESS, (
105105
f"Account key rotation to KeyList failed with status: {ResponseCode(receipt.status).name}"
106106
)

tests/integration/batch_transaction_e2e_test.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
from hiero_sdk_python.crypto.private_key import PrivateKey
99
from hiero_sdk_python.crypto.public_key import PublicKey
1010
from hiero_sdk_python.file.file_id import FileId
11+
from hiero_sdk_python.hbar import Hbar
1112
from hiero_sdk_python.query.account_info_query import AccountInfoQuery
1213
from hiero_sdk_python.query.transaction_get_receipt_query import TransactionGetReceiptQuery
1314
from hiero_sdk_python.response_code import ResponseCode
@@ -96,6 +97,7 @@ def test_batch_transaction_can_execute_large_batch(env):
9697

9798
batch_tx.add_inner_transaction(transfer_tx)
9899

100+
batch_tx.transaction_fee = Hbar.from_hbars(10)
99101
batch_tx.freeze_with(env.client)
100102
batch_tx.sign(batch_key)
101103

tests/integration/ethereum_transaction_e2e_test.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,9 @@ def test_integration_ethereum_transaction_jumbo_transaction(env):
147147
alias_private_key,
148148
)
149149

150-
receipt = EthereumTransaction().set_ethereum_data(transaction_data).execute(env.client)
150+
tx = EthereumTransaction().set_ethereum_data(transaction_data)
151+
tx.transaction_fee = Hbar.from_hbars(10)
152+
receipt = tx.execute(env.client)
151153
assert receipt.status == ResponseCode.SUCCESS, (
152154
f"Ethereum transaction failed with status: {ResponseCode(receipt.status).name}"
153155
)

0 commit comments

Comments
 (0)