[Everything] DIE MRI ALIAS DIE

[ridz1208]

Someone please check I didnt break everything

please review getCenterNameFromCenterID I don't speak this language

[maximemulder]

Code LGTM. Haven't tested the changes. Some personal naming opinions but feel free to ignore or only partially apply if you prefer.

[maximemulder]

Personal opinion: I would prefer this function to be named getSiteMRIAliasFromSiteID.

• "center" is used pervasively in the LORIS code but Samir said in some LORIS / LORIS-MRI meeting that "site" is the preferred terminology. Since it does against the current code I guess this is somewhat controversial.
• A "site name" refers to another column in the database, so I think it would be less confusing to specify "MRIAlias" directly.

[ridz1208]

I'll avoid the entire situation and change it to getMRIAliasFromCenterID()

[cmadjar]

Is there a reason why we are getting rid of the CenterName? When printing in the logs, I think it is more human readable to read the CenterName than an ID referring to a site.

@nicolasbrossard thoughts?

Also, one tiny code change suggested below to make my brain happy ;)

[ridz1208]

@cmadjar good point I'll fetch the name instead I did it in another class for the Alias, remember? the place that triggered your OCD :p

[cmadjar]

@ridz1208 sounds good. Let me know when implemented and I will test it on my MCIN sandbox. In the meantime, I will update my MCIN sandbox so it is ready for testing. Will update to a commit before the CandID refactoring, I am pretty sure that schema change is going to break a lot of things on the MRI pipeline 😨

[cmadjar]

@nicolasbrossard existential question: why is there MRI alias in the log filename?

[github-actions]

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 20 days.

[MaximeBICMTL]

@ridz1208, while I have no problem merging this PR as-is, do you want to also remove MRI_Alias from the database schema and the Python code?

If so, the following steps should be done:

1. Open a PR on the main LORIS repo to remove the field from the schema and PHP code.
2. Remove references to MRI_Alias in the Python code as well.
3. Rebase this PR on the main branch to benefit from our super very cool improved integration tests (only applies to Python, Perl is still very much untested).

If you want to I can take care of all that (easy work), in this PR or a follow-up one.

[ridz1208]

@MaximeBICMTL

1. I would refrain from removing it just yet formt he LORIS side, in case projects are using it, I will check first if we need to deprecate it first and remove it next version
2. good point
3. good point

@hansfauer may or may not be taking this one over, if he is, I will let him handle the rebase and the pyhton.