Simplify EEG/MEG signal chunking signature#1395
Merged
MaximeBICMTL merged 1 commit intoMar 21, 2026
Merged
Conversation
github-actions
Bot
added
the
Language: Python
MaximeBICMTL
added
Category: Refactor
MaximeBICMTL
force-pushed
the
simplify_eeg_chunking_signature
branch
from
0876ecb to
baf8b62
Compare
jeffersoncasimir
approved these changes
Mar 18, 2026
MaximeBICMTL
added a commit
that referenced
this pull request
Mar 26, 2026
MaximeBICMTL
added
the
Category: Bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the
lib.physio.chunking.create_physio_channels_chunkstook a separate parameter for the path of the file to chunk, this was done for the work-in-progress MEG implementation where in a previous design, the path of the "real" file may not have been the path of the physiological file. That work-in-progress MEG design is obsolete thanks to aces/Loris#10411, so this additional parameter is no longer needed.This PR also fixes a bug where the created chunk directories had an incorrect name.