LORIS BIDS importer package (PR 2)#1425
Open
MaximeBICMTL wants to merge 2 commits into
Open
Conversation
4a0848d to
345cff3
Compare
345cff3 to
eb62f84
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #1424 (diff)
Description
This PR isolates the LORIS BIDS importer out of the core
libmodule into its ownloris-bids-importerpackage.List of changes
Architecture
scriptsandlib.import_bids_datasetmodules to a newloris-bids-importerpackage, which is installed by default with LORIS Python.EegandPhysiologicalclasses to this new package.check_or_create_subject/session(params, create=False)functions tovalidate_subject/session(params, create=False)to be more concise and better emphasize the validation step of the pipeline.loris-bids-importerto better organize the files.Old file structure:
New file structure:
Documentation
Added a README file to the new package. Included MEG because I don't want to change the README soon. Did not talk about
default_bids_vlbecause it is a horrible design (it should be a CLI parameter, not a global config value).CLI parameters (breaking changes)
Renamed the BIDS importer command from
import_bids_dataset.py(bids_import.pyin LORIS 27) toimport-bids-dataset.Renamed CLI options to use kebab-case:
--createcandidate→--create-candidate--createsession→--create-session--nobidsvalidation→--no-bids-validation--nocopy→--no-copy