Better BIDS TSV reader typing (PR 3)#1426
Open
MaximeBICMTL wants to merge 3 commits into
Open
Conversation
03c6979 to
3a6812f
Compare
3a6812f to
5c38406
Compare
5c38406 to
32c9d8f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #1425 (diff)
Description
Improve the LORIS BIDS reader TSV row typing by typing row data as
dict[str, str | None]instead ofdict[str, Any]. This loose typing was inherited from the old code, which read and modified the row data directly, which notably caused some bugs such as code usingisisntance(row.data['field'], int | float)which is alwaysFalsesince raw tsv data is always a string (orNone). The new approach stores the data LORIS is interested in in dedicated fields while the raw data remains unchanged.Potential follow-ups
n/avalues byNoneon parsing (I think we should do that, it makes the code easier and more intuitive with no real information loss IMO).