Skip to content

[dataquery + login] Translate Terms of Use menu label and popup text#10392

Closed
arnav-makkar wants to merge 1 commit into
aces:mainfrom
arnav-makkar:fix/10263-terms-of-use-translation
Closed

[dataquery + login] Translate Terms of Use menu label and popup text#10392
arnav-makkar wants to merge 1 commit into
aces:mainfrom
arnav-makkar:fix/10263-terms-of-use-translation

Conversation

@arnav-makkar

Copy link
Copy Markdown
Contributor

Brief summary of changes

  • Updated shared policy rendering so Terms of Use is localized consistently across both login and dataquery views.
  • Refactored PolicyButton to use withTranslation('loris') and literal t(...) msgids for default policy entries (dataquery_example, login_example).
  • Added translation coverage for the policy nav label, popup title, popup body, and accept/decline button text.
  • Preserved safe fallback behavior: unmapped policy names/fields continue to display backend-provided text unchanged.
  • Added translation entries for all supported UI languages (en, fr, ja, hi, es).

I do not have experience with Spanish or Japanese, so a strict review will be required for these translations.
Please let me know whatever changes required, and I'll be happy to incorporate them!

Screenshots

Dataquery Tool:
Screenshot 2026-03-06 at 01 08 04
Screenshot 2026-03-06 at 01 10 44
Screenshot 2026-03-06 at 01 07 44

Login Page:
Screenshot 2026-03-06 at 01 08 17
Screenshot 2026-03-06 at 01 08 45
Screenshot 2026-03-06 at 01 08 59

Link(s) to related issue(s)

@github-actions github-actions Bot added Language: Javascript PR or issue that update Javascript code Multilingual Any tasks related to making LORIS multilingual labels Mar 5, 2026
@CamilleBeau CamilleBeau added the Critical to release PR or issue is key for the release to which it has been assigned label May 19, 2026

@skarya22 skarya22 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately I think this needs to be redone -- For DB translations, we are creating pot files named after the DB Table such as Project in #10466, and then getting the values for that DB translation such as in #10462 where we get them from the Project pot for the Project table.

However, for a table like policies, we should copy the Config settings translations like in #9994

@skarya22 skarya22 added the State: Needs work PR awaiting additional work by the author to proceed label May 27, 2026
@CamilleBeau

Copy link
Copy Markdown
Collaborator

Closing this since it was done in #10513

@CamilleBeau CamilleBeau closed this Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Critical to release PR or issue is key for the release to which it has been assigned Language: Javascript PR or issue that update Javascript code Multilingual Any tasks related to making LORIS multilingual State: Needs work PR awaiting additional work by the author to proceed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[dataquery + login] "Terms of Use" not translated

3 participants