[dataquery + login] Translate Terms of Use menu label and popup text#10392
Closed
arnav-makkar wants to merge 1 commit into
Closed
[dataquery + login] Translate Terms of Use menu label and popup text#10392arnav-makkar wants to merge 1 commit into
arnav-makkar wants to merge 1 commit into
Conversation
skarya22
requested changes
May 27, 2026
Contributor
There was a problem hiding this comment.
Unfortunately I think this needs to be redone -- For DB translations, we are creating pot files named after the DB Table such as Project in #10466, and then getting the values for that DB translation such as in #10462 where we get them from the Project pot for the Project table.
However, for a table like policies, we should copy the Config settings translations like in #9994
Collaborator
|
Closing this since it was done in #10513 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
PolicyButtonto usewithTranslation('loris')and literalt(...)msgids for default policy entries (dataquery_example,login_example).I do not have experience with Spanish or Japanese, so a strict review will be required for these translations.
Please let me know whatever changes required, and I'll be happy to incorporate them!
Screenshots
Dataquery Tool:



Login Page:



Link(s) to related issue(s)