[electrophysiology_browser] Dynamic channel metadata and visualization#10470
Draft
MaximeBICMTL wants to merge 3 commits intoaces:mainfrom
Draft
[electrophysiology_browser] Dynamic channel metadata and visualization#10470MaximeBICMTL wants to merge 3 commits intoaces:mainfrom
MaximeBICMTL wants to merge 3 commits intoaces:mainfrom
Conversation
0b778c6 to
15b85a9
Compare
15b85a9 to
1339962
Compare
MaximeBICMTL
commented
May 5, 2026
Comment on lines
+36
to
+37
| lowerPercentile = 5, | ||
| upperPercentile = 95, |
Contributor
Author
There was a problem hiding this comment.
We should probably remove this rule from the Javascript linter IMO, I don't like not being able to specify the type of my parameters.
33:3 error Type number trivially inferred from a number literal, remove type annotation @typescript-eslint/no-inferrable-types
34:3 error Type number trivially inferred from a number literal, remove type annotation @typescript-eslint/no-inferrable-types
factorize get channel values dynamic visible channel type range
1339962 to
9d3ca29
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #10403
Description
This PR adds support for usable MEG display in the electrophysiology browser by replacing hard-coded EEG values with dynamic values based on the channel metadata and signal.
Features
Design choices
channels.tsvfields, read through the LORIS API (just like the type in the channel types).Architecture
This PR also moves the channel metadata and BIDS channel information from the Redux-based state management to React contexts, which reduces prop drilling and makes them easier to use throughout the electrophysiology browser.
Backward-compatibility
This PR is backward-compatible with existing EEG acquisitions. If some metadata is not found, this PR falls back to assuming the acquisition is an EEG acquisition.
Performance:
This PR adds a O(n) scan on the signal values of visible channels to get the signal range. This did not cause noticeable lags in my tests even with 64 displayed channels.
Potential improvements
All these improvements can be added later IMO (although more metadata extract requires re-running the electrophysiology chunker script) and are easier to implement after this PR rather than before.
Screenshots
For the MPN MEG dataset:
[TODO]
For the EEG Face13 dataset:
[TODO]