Skip to content

Surface#380

Merged
natacha-beck merged 7 commits into
aces:masterfrom
natacha-beck:surface
Apr 1, 2026
Merged

Surface#380
natacha-beck merged 7 commits into
aces:masterfrom
natacha-beck:surface

Conversation

@natacha-beck
Copy link
Copy Markdown
Contributor

No description provided.

@MontrealSergiy
Copy link
Copy Markdown
Contributor

Should I test it on different surfaces?

Seems like a lot of unrelated commits, needs a clean up

@prioux
Copy link
Copy Markdown
Member

prioux commented Feb 17, 2026

I do not like the name of the new file model "AscFile"; people will see this and use it for normal text files, thinking it is for ASCII files, not realizing it's supposed ot be for text files WITH a special 3D content. So I suggest it to be renamed "Asc3dFile" instead. Filename: "asc3d_file/asc3d_file.rb"

@MontrealSergiy
Copy link
Copy Markdown
Contributor

MontrealSergiy commented Feb 17, 2026

Maybe AscSurfaceFile or AscFreeSurferFile?

@prioux
Copy link
Copy Markdown
Member

prioux commented Feb 17, 2026

It's up to Natacha to choose.

@natacha-beck natacha-beck marked this pull request as draft February 27, 2026 12:18
natacha-beck and others added 2 commits March 3, 2026 16:01
@natacha-beck natacha-beck marked this pull request as ready for review March 5, 2026 14:22
@natacha-beck
Copy link
Copy Markdown
Contributor Author

natacha-beck commented Mar 5, 2026

@MontrealSergiy MontrealSergiy linked an issue Mar 5, 2026 that may be closed by this pull request
@MontrealSergiy
Copy link
Copy Markdown
Contributor

I get some bugs

I registered a gziped file add link brain-surface.obj.gz as 3D Obj - got an exception when opening it
Missing template home/users/sboroday/cbrain/BrainPortal/cbrain_plugins/installed-plugins/views/surface_file/javascripts/_brainbrowser_surface with {:locale=>[:en], :formats=>[:html], :variants=>[], :handlers=>[:raw, :erb, :html, :builder, :ruby]}.

@MontrealSergiy
Copy link
Copy Markdown
Contributor

even head.defaced.surf (FreeSurfer Surface) .. not sure maybe I did not install something propertly ..

Copy link
Copy Markdown
Contributor

@MontrealSergiy MontrealSergiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the surface files within a file collection seem to be rendered, but standalone surface file are not rendered.

Copy link
Copy Markdown
Contributor

@MontrealSergiy MontrealSergiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems work now

@natacha-beck natacha-beck merged commit e42b938 into aces:master Apr 1, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generalise usage of BrainBrowser for surface file.

3 participants