Merge pull request YimMenu-Lua#132 from YimMenu-Lua/classes_utils_fixes

fix: miscellaneous fixes + code cleanup

Author: xesdoog

.github/workflows/translations.yml

@@ -2,6 +2,8 @@ name: Generate Translations
 
 on:
   push:
+    branches:
+      - main
     paths:
       - "dev/scripts/translations/**"
       - "SSV2/includes/lib/translations/en-US.lua"

.github/workflows/zip-release.yml

@@ -110,12 +110,9 @@ jobs:
           let breaking = false;
           let breakingMsg = ">[!Important]\n>**This is a breaking change**\n>To install this update, please remove the previous version completely and then install the new version.\n\n";
 
-          function isBreakingChange(str) {
-            return str.toLowerCase().includes("breaking change");
-          }
+          function isBreakingChange(str) { return str.toLowerCase().includes("breaking change"); }
 
           const mergedPRs = pulls.filter(pr => pr.merged_at && new Date(pr.merged_at) > lastTagDate);
-
           if (mergedPRs.length > 0) {
             for (const pr of mergedPRs) {
               changelog += `### PR #${pr.number}: ${pr.title}\n`;
@@ -125,29 +122,27 @@ jobs:
                 changelog += `${body.trim()}\n\n`;
               }
             }
-          } else {
-            const compared = await github.rest.repos.compareCommits({
-              owner,
-              repo,
-              base: lastTag,
-              head: "main"
-            });
-
-            const commits = compared.data.commits;
-            for (const commit of commits) {
-              const msg = commit.commit.message || "";
-              const body = commit.commit.body;
-
-              if (msg.toLowerCase().startsWith("merge pull"))
-                continue;
-
-              breaking = breaking || isBreakingChange(msg);
-              changelog += `## ${msg}\n\n`;
+          }
 
-              if (body) {
-                breaking = breaking || isBreakingChange(body);
-                changelog += `${body.trim()}\n\n`;
-              }
+          const compared = await github.rest.repos.compareCommits({
+            owner,
+            repo,
+            base: lastTag,
+            head: "main"
+          });
+          const commits = compared.data.commits;
+          for (const commit of commits) {
+            const msg = commit.commit.message || "";
+            const body = commit.commit.body;
+            const msgLower = msg.toLowerCase();
+            if (msgLower.startsWith("merge ") || msgLower.startsWith("[noci]"))
+              continue;
+
+            breaking = breaking || isBreakingChange(msg);
+            changelog += `## ${msg}\n\n`;
+            if (body) {
+              breaking = breaking || isBreakingChange(body);
+              changelog += `${body.trim()}\n\n`;
             }
           }
 

SSV2/includes/classes/gta/CBaseSubHandlingData.lua

@@ -5,6 +5,8 @@
 -- this code as long as you respect these conditions:
 --	* Credit the owner and contributors.
 --	* Provide a copy of or a link to the original license (GPL-3.0 or later); see LICENSE.md or <https://www.gnu.org/licenses/>.
+--
+-- Converted from Yimura's C++ GTA V Classes: https://github.com/Yimura/GTAV-Classes (forked here: https://github.com/Mr-X-GTA/GTAV-Classes-1)
 
 
 local CStructView = require("includes.classes.gta.CStructView")

SSV2/includes/classes/gta/CBikeHandlingData.lua

@@ -7,7 +7,6 @@
 --	* Provide a copy of or a link to the original license (GPL-3.0 or later); see LICENSE.md or <https://www.gnu.org/licenses/>.
 
 
-local CStructView          = require("includes.classes.gta.CStructView")
 local CBaseSubHandlingData = require("includes.classes.gta.CBaseSubHandlingData")
 
 

SSV2/includes/classes/gta/CBoatHandlingData.lua

@@ -7,7 +7,6 @@
 --	* Provide a copy of or a link to the original license (GPL-3.0 or later); see LICENSE.md or <https://www.gnu.org/licenses/>.
 
 
-local CStructView = require("includes.classes.gta.CStructView")
 local CBaseSubHandlingData = require("includes.classes.gta.CBaseSubHandlingData")
 
 

SSV2/includes/classes/gta/CCarHandlingData.lua

@@ -5,6 +5,8 @@
 -- this code as long as you respect these conditions:
 --	* Credit the owner and contributors.
 --	* Provide a copy of or a link to the original license (GPL-3.0 or later); see LICENSE.md or <https://www.gnu.org/licenses/>.
+--
+-- Converted from Yimura's C++ GTA V Classes: https://github.com/Yimura/GTAV-Classes (forked here: https://github.com/Mr-X-GTA/GTAV-Classes-1)
 
 
 local atArray              = require("includes.classes.gta.atArray")

SSV2/includes/classes/gta/CEntity.lua

@@ -5,11 +5,12 @@
 -- this code as long as you respect these conditions:
 --	* Credit the owner and contributors.
 --	* Provide a copy of or a link to the original license (GPL-3.0 or later); see LICENSE.md or <https://www.gnu.org/licenses/>.
+--
+-- Converted from Yimura's C++ GTA V Classes: https://github.com/Yimura/GTAV-Classes (forked here: https://github.com/Mr-X-GTA/GTAV-Classes-1)
 
 
 local fwDrawData = require("includes.classes.gta.fwDrawData")
 
-
 ---@class CBaseModelInfo
 ---@class CAttackers
 

SSV2/includes/classes/gta/CFiringPatternAlias.lua

@@ -5,6 +5,8 @@
 -- this code as long as you respect these conditions:
 --	* Credit the owner and contributors.
 --	* Provide a copy of or a link to the original license (GPL-3.0 or later); see LICENSE.md or <https://www.gnu.org/licenses/>.
+--
+-- Converted from Yimura's C++ GTA V Classes: https://github.com/Yimura/GTAV-Classes (forked here: https://github.com/Mr-X-GTA/GTAV-Classes-1)
 
 
 local CStructView = require("includes.classes.gta.CStructView")

SSV2/includes/classes/gta/CHandlingData.lua

@@ -5,6 +5,8 @@
 -- this code as long as you respect these conditions:
 --	* Credit the owner and contributors.
 --	* Provide a copy of or a link to the original license (GPL-3.0 or later); see LICENSE.md or <https://www.gnu.org/licenses/>.
+--
+-- Converted from Yimura's C++ GTA V Classes: https://github.com/Yimura/GTAV-Classes (forked here: https://github.com/Mr-X-GTA/GTAV-Classes-1)
 
 
 local atArray                    = require("includes.classes.gta.atArray")

SSV2/includes/classes/gta/CPed.lua

@@ -5,6 +5,8 @@
 -- this code as long as you respect these conditions:
 --	* Credit the owner and contributors.
 --	* Provide a copy of or a link to the original license (GPL-3.0 or later); see LICENSE.md or <https://www.gnu.org/licenses/>.
+--
+-- Converted from Yimura's C++ GTA V Classes: https://github.com/Yimura/GTAV-Classes (forked here: https://github.com/Mr-X-GTA/GTAV-Classes-1)
 
 
 local CEntity           = require("includes.classes.gta.CEntity")