Skip to content

Commit bdd266f

Browse files
authored
feat(models): add database_specific to AffectedRange2 (google#4201)
google#4160 adds a `database_specific` field to the affected ranges in proto. This PR aligns the NDB model for this change. This ensures that any database-specific metadata provided in a vulnerability's affected range is correctly persisted in the datastore and included in the API output.
1 parent 41febde commit bdd266f

25 files changed

Lines changed: 77 additions & 33 deletions

gcp/workers/worker/testdata/ImpactTest_basic.txt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,8 @@
55
'package': { 'ecosystem': 'ecosystem',
66
'name': 'project',
77
'purl': None},
8-
'ranges': [ { 'events': [ { 'type': 'introduced',
8+
'ranges': [ { 'database_specific': None,
9+
'events': [ { 'type': 'introduced',
910
'value': 'eefe8ec3f1f90d0e684890e810f3f21e8500a4cd'},
1011
{ 'type': 'fixed',
1112
'value': '8d8242f545e9cec3e6d0d2e3f5bde8be1c659735'},

gcp/workers/worker/testdata/ImpactTest_fixed_range_too_long.txt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,8 @@
55
'package': { 'ecosystem': 'ecosystem',
66
'name': 'project',
77
'purl': None},
8-
'ranges': [ { 'events': [ { 'type': 'introduced',
8+
'ranges': [ { 'database_specific': None,
9+
'events': [ { 'type': 'introduced',
910
'value': 'eefe8ec3f1f90d0e684890e810f3f21e8500a4cd'},
1011
{ 'type': 'fixed',
1112
'value': 'b587c21c36a84e16cfc6b39eb68578d43b5281ad'}],

gcp/workers/worker/testdata/ImpactTest_not_fixed.txt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,8 @@
55
'package': { 'ecosystem': 'ecosystem',
66
'name': 'project',
77
'purl': None},
8-
'ranges': [ { 'events': [ { 'type': 'introduced',
8+
'ranges': [ { 'database_specific': None,
9+
'events': [ { 'type': 'introduced',
910
'value': 'eefe8ec3f1f90d0e684890e810f3f21e8500a4cd'},
1011
{ 'type': 'introduced',
1112
'value': 'febfac1940086bc1f6d3dc33fda0a1d1ba336209'}],

gcp/workers/worker/testdata/ImpactTest_range.txt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,8 @@
55
'package': { 'ecosystem': 'ecosystem',
66
'name': 'project',
77
'purl': None},
8-
'ranges': [ { 'events': [ { 'type': 'introduced',
8+
'ranges': [ { 'database_specific': None,
9+
'events': [ { 'type': 'introduced',
910
'value': 'eefe8ec3f1f90d0e684890e810f3f21e8500a4cd'},
1011
{ 'type': 'fixed',
1112
'value': '36f0bd9549298b44f9ff2496c9dd1326b3a9d0e2'}],

gcp/workers/worker/testdata/ImpactTest_simplify_range.txt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,8 @@
55
'package': { 'ecosystem': 'ecosystem',
66
'name': 'project',
77
'purl': None},
8-
'ranges': [ { 'events': [ { 'type': 'introduced',
8+
'ranges': [ { 'database_specific': None,
9+
'events': [ { 'type': 'introduced',
910
'value': 'eefe8ec3f1f90d0e684890e810f3f21e8500a4cd'},
1011
{ 'type': 'fixed',
1112
'value': '8d8242f545e9cec3e6d0d2e3f5bde8be1c659735'},

gcp/workers/worker/testdata/ImpactTest_zero_regression_range.txt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,8 @@
55
'package': { 'ecosystem': 'ecosystem',
66
'name': 'project',
77
'purl': None},
8-
'ranges': [ { 'events': [ { 'type': 'introduced',
8+
'ranges': [ { 'database_specific': None,
9+
'events': [ { 'type': 'introduced',
910
'value': 'eefe8ec3f1f90d0e684890e810f3f21e8500a4cd'},
1011
{ 'type': 'fixed',
1112
'value': '8d8242f545e9cec3e6d0d2e3f5bde8be1c659735'}],

gcp/workers/worker/testdata/RESTUpdateTest_update_no_introduced.txt

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -181,13 +181,15 @@
181181
'package': { 'ecosystem': '',
182182
'name': '',
183183
'purl': None},
184-
'ranges': [ { 'events': [ { 'type': 'introduced',
184+
'ranges': [ { 'database_specific': None,
185+
'events': [ { 'type': 'introduced',
185186
'value': '7.7'},
186187
{ 'type': 'fixed',
187188
'value': '7.86.0'}],
188189
'repo_url': '',
189190
'type': 'SEMVER'},
190-
{ 'events': [ { 'type': 'introduced',
191+
{ 'database_specific': None,
192+
'events': [ { 'type': 'introduced',
191193
'value': '546572da0457f37c698c02d0a08d90fdfcbeedec'},
192194
{ 'type': 'fixed',
193195
'value': 'a64e3e59938abd7d667e4470a18072a24d7e9de9'}],

gcp/workers/worker/testdata/UpdateTest_dont_index_too_many_git_versions.txt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,8 @@
55
'package': { 'ecosystem': '',
66
'name': '',
77
'purl': None},
8-
'ranges': [ { 'events': [ { 'type': 'introduced',
8+
'ranges': [ { 'database_specific': None,
9+
'events': [ { 'type': 'introduced',
910
'value': 'eefe8ec3f1f90d0e684890e810f3f21e8500a4cd'},
1011
{ 'type': 'last_affected',
1112
'value': '8d8242f545e9cec3e6d0d2e3f5bde8be1c659735'}],

gcp/workers/worker/testdata/UpdateTest_last_affected_git.txt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,8 @@
55
'package': { 'ecosystem': '',
66
'name': '',
77
'purl': None},
8-
'ranges': [ { 'events': [ { 'type': 'introduced',
8+
'ranges': [ { 'database_specific': None,
9+
'events': [ { 'type': 'introduced',
910
'value': 'eefe8ec3f1f90d0e684890e810f3f21e8500a4cd'},
1011
{ 'type': 'last_affected',
1112
'value': '8d8242f545e9cec3e6d0d2e3f5bde8be1c659735'}],

gcp/workers/worker/testdata/UpdateTest_normalized_pypi.txt

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,15 @@
55
'package': { 'ecosystem': 'PyPI',
66
'name': 'scrapy',
77
'purl': 'pkg:pypi/scrapy'},
8-
'ranges': [ { 'events': [ { 'type': 'introduced',
8+
'ranges': [ { 'database_specific': None,
9+
'events': [ { 'type': 'introduced',
910
'value': '1.14.2'},
1011
{ 'type': 'fixed',
1112
'value': '1.31.0'}],
1213
'repo_url': '',
1314
'type': 'ECOSYSTEM'},
14-
{ 'events': [ { 'type': 'introduced',
15+
{ 'database_specific': None,
16+
'events': [ { 'type': 'introduced',
1517
'value': 'eefe8ec3f1f90d0e684890e810f3f21e8500a4cd'},
1618
{ 'type': 'fixed',
1719
'value': '8d8242f545e9cec3e6d0d2e3f5bde8be1c659735'}],

0 commit comments

Comments
 (0)