fix(cli): improve ssh warnings and tmux copy

Author: acmore

infra/sidecar/embedded-tmux.conf

@@ -13,6 +13,8 @@ set -g set-clipboard on
 set -g default-terminal "tmux-256color"
 
 setw -g mode-keys vi
+bind -T copy-mode MouseDragEnd1Pane send-keys -X copy-selection-and-cancel
+bind -T copy-mode-vi MouseDragEnd1Pane send-keys -X copy-selection-and-cancel
 
 set -g status-position bottom
 set -g status-interval 5

infra/sidecar/tmux.conf

@@ -17,6 +17,8 @@ set -g default-terminal "tmux-256color"
 
 # Prefer vi keys in copy mode for logs/code.
 setw -g mode-keys vi
+bind -T copy-mode MouseDragEnd1Pane send-keys -X copy-selection-and-cancel
+bind -T copy-mode-vi MouseDragEnd1Pane send-keys -X copy-selection-and-cancel
 
 # Route new windows and panes through the dev-shell wrapper so tmux always
 # lands in the dev container rather than the sidecar.

internal/cli/ssh.go

@@ -167,7 +167,7 @@ func newSSHCmd(opts *Options) *cobra.Command {
 				})
 				var lastRTTWarnNanos atomic.Int64
 				tm.SetKeepAliveRTTCallback(func(rtt time.Duration) {
-					if rtt < 2*time.Second {
+					if rtt < 5*time.Second {
 						return
 					}
 					now := time.Now().UnixNano()
@@ -176,7 +176,7 @@ func newSSHCmd(opts *Options) *cobra.Command {
 						return
 					}
 					if lastRTTWarnNanos.CompareAndSwap(prev, now) {
-						fmt.Fprintf(cmd.ErrOrStderr(), "warning: ssh keepalive RTT is high: %s\n", rtt.Round(10*time.Millisecond))
+						fmt.Fprintf(cmd.ErrOrStderr(), "warning: ssh keepalive RTT is very high: %s\n", rtt.Round(10*time.Millisecond))
 					}
 				})
 				stopConnect := startTransientStatus(errOut, "Connecting to session")

internal/cli/up.go

@@ -435,8 +435,7 @@ func detectEmbeddedTmux(ctx context.Context, k devShellExecutor, namespace, pod
 }
 
 func installEmbeddedTmux(ctx context.Context, k devShellExecutor, namespace, pod, installer string, progress func(string)) (bool, string, error) {
-	installCtx, cancel := context.WithTimeout(ctx, 3*time.Minute)
-	defer cancel()
+	installCtx := ctx
 	if progress != nil && installer != "" && installer != "none" {
 		ticker := time.NewTicker(10 * time.Second)
 		defer ticker.Stop()
@@ -458,8 +457,11 @@ func installEmbeddedTmux(ctx context.Context, k devShellExecutor, namespace, pod
 	var raw bytes.Buffer
 	err := k.StreamShInContainer(installCtx, namespace, pod, "dev", script, &raw, &raw)
 	if err != nil {
-		if errors.Is(installCtx.Err(), context.DeadlineExceeded) {
-			return false, "", fmt.Errorf("timed out while installing tmux via %s; inspect %s in the dev container", installer, embeddedTmuxLogPath)
+		if errors.Is(ctx.Err(), context.DeadlineExceeded) {
+			return false, "", fmt.Errorf("tmux install cancelled after timeout via parent context; inspect %s in the dev container", embeddedTmuxLogPath)
+		}
+		if errors.Is(ctx.Err(), context.Canceled) {
+			return false, "", fmt.Errorf("tmux install cancelled; inspect %s in the dev container", embeddedTmuxLogPath)
 		}
 		return false, "", err
 	}