fix(cli): clear config status in list output

Author: acmore

internal/cli/list.go

@@ -25,12 +25,10 @@ func newListCmd(opts *Options) *cobra.Command {
 				return activeErr
 			}
 			if ns == "" {
-				if cfg, path, err := config.Load(opts.ConfigPath); err == nil && cfg.Spec.Namespace != "" {
+				if cfg, err := loadOptionalConfigForList(opts, announceConfigPath); err == nil && cfg.Spec.Namespace != "" {
 					ns = cfg.Spec.Namespace
-					announceConfigPath(path)
 					applyConfigKubeContext(opts, cfg)
 				} else if err == nil {
-					announceConfigPath(path)
 					applyConfigKubeContext(opts, cfg)
 				}
 			}
@@ -109,3 +107,17 @@ func sessionNameFromPodSummary(p kube.PodSummary) string {
 	}
 	return name
 }
+
+func loadOptionalConfigForList(opts *Options, announce func(string) func(bool)) (*config.DevEnvironment, error) {
+	path, err := config.ResolvePath(opts.ConfigPath)
+	if err != nil {
+		return nil, err
+	}
+	done := announce(path)
+	cfg, _, err := config.Load(path)
+	done(err == nil)
+	if err != nil {
+		return nil, err
+	}
+	return cfg, nil
+}

internal/cli/list_test.go

@@ -0,0 +1,55 @@
+package cli
+
+import (
+	"os"
+	"path/filepath"
+	"testing"
+
+	"github.com/acmore/okdev/internal/config"
+)
+
+func TestLoadOptionalConfigForListAnnouncesAndStops(t *testing.T) {
+	dir := t.TempDir()
+	cfgPath := filepath.Join(dir, config.DefaultFile)
+	if err := os.WriteFile(cfgPath, []byte(`
+apiVersion: okdev.io/v1alpha1
+kind: DevEnvironment
+metadata:
+  name: test
+spec:
+  namespace: team-a
+  sidecar:
+    image: ghcr.io/acmore/okdev:edge
+`), 0o644); err != nil {
+		t.Fatalf("write config: %v", err)
+	}
+
+	var announcedPath string
+	var doneCalled bool
+	var doneSuccess bool
+	cfg, err := loadOptionalConfigForList(&Options{ConfigPath: cfgPath}, func(path string) func(bool) {
+		announcedPath = path
+		return func(success bool) {
+			doneCalled = true
+			doneSuccess = success
+		}
+	})
+	if err != nil {
+		t.Fatalf("loadOptionalConfigForList returned error: %v", err)
+	}
+	if cfg == nil {
+		t.Fatal("expected config")
+	}
+	if cfg.Spec.Namespace != "team-a" {
+		t.Fatalf("expected namespace team-a, got %q", cfg.Spec.Namespace)
+	}
+	if announcedPath != cfgPath {
+		t.Fatalf("expected announced path %q, got %q", cfgPath, announcedPath)
+	}
+	if !doneCalled {
+		t.Fatal("expected announce completion callback to be called")
+	}
+	if !doneSuccess {
+		t.Fatal("expected announce completion callback to report success")
+	}
+}