refactor: remove dead sshSpec parameter from ensureSSHConfigEntry

Keepalive values are now hardcoded, so the sshSpec parameter was unused.
Removed from function signature and all call sites.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: acmore

internal/cli/ports.go

@@ -62,7 +62,7 @@ func newPortsCmd(opts *Options) *cobra.Command {
 				return fmt.Errorf("wait for sshd ready: %w", err)
 			}
 			alias := sshHostAlias(sn)
-			changed, err := ensureSSHConfigEntry(alias, sn, ns, cfg.Spec.SSH.User, effectiveSSHPort, keyPath, cfgPath, cfg.Spec.Ports, cfg.Spec.SSH)
+			changed, err := ensureSSHConfigEntry(alias, sn, ns, cfg.Spec.SSH.User, effectiveSSHPort, keyPath, cfgPath, cfg.Spec.Ports)
 			if err != nil {
 				return fmt.Errorf("update ~/.ssh/config for managed forwards: %w", err)
 			}

internal/cli/ssh.go

@@ -123,7 +123,7 @@ func newSSHCmd(opts *Options) *cobra.Command {
 				sshHost := sshHostAlias(sn)
 				cfgPath, _ := config.ResolvePath(opts.ConfigPath)
 				stopSSHConfig := startTransientStatus(errOut, "Preparing SSH config")
-				if _, cfgErr := ensureSSHConfigEntry(sshHost, sn, ns, user, remotePort, keyPath, cfgPath, cfg.Spec.Ports, cfg.Spec.SSH); cfgErr != nil {
+				if _, cfgErr := ensureSSHConfigEntry(sshHost, sn, ns, user, remotePort, keyPath, cfgPath, cfg.Spec.Ports); cfgErr != nil {
 					stopSSHConfig()
 					fmt.Fprintf(errOut, "warning: failed to update ~/.ssh/config: %v\n", cfgErr)
 				} else {
@@ -410,7 +410,7 @@ func sshHostAlias(sessionName string) string {
 	return "okdev-" + sessionName
 }
 
-func ensureSSHConfigEntry(hostAlias, sessionName, namespace, user string, remotePort int, keyPath, okdevConfigPath string, forwards []config.PortMapping, sshSpec config.SSHSpec) (bool, error) {
+func ensureSSHConfigEntry(hostAlias, sessionName, namespace, user string, remotePort int, keyPath, okdevConfigPath string, forwards []config.PortMapping) (bool, error) {
 	home, err := os.UserHomeDir()
 	if err != nil {
 		return false, err

internal/cli/ssh_config_test.go

@@ -28,7 +28,6 @@ func TestEnsureSSHConfigEntryIncludesNamespaceInProxyCommand(t *testing.T) {
 		"/tmp/id_ed25519",
 		"/tmp/.okdev.yaml",
 		[]config.PortMapping{{Local: 8080, Remote: 8080}},
-		config.SSHSpec{KeepAliveInterval: 30, KeepAliveCountMax: 10},
 	)
 	if err != nil {
 		t.Fatalf("ensureSSHConfigEntry: %v", err)
@@ -61,7 +60,7 @@ func TestEnsureSSHConfigEntryUsesProxyKeepaliveValues(t *testing.T) {
 		_ = os.Setenv("HOME", origHome)
 	}()
 
-	// Pass config defaults (10/30) — the written config should still use 5/10
+	// Keepalive values are hardcoded — verify they're 5/10 regardless of config defaults
 	_, err := ensureSSHConfigEntry(
 		"okdev-test2",
 		"test-session2",
@@ -71,7 +70,6 @@ func TestEnsureSSHConfigEntryUsesProxyKeepaliveValues(t *testing.T) {
 		"/tmp/id_ed25519",
 		"/tmp/.okdev.yaml",
 		nil,
-		config.SSHSpec{KeepAliveInterval: 10, KeepAliveCountMax: 30},
 	)
 	if err != nil {
 		t.Fatalf("ensureSSHConfigEntry: %v", err)

internal/cli/up.go

@@ -174,7 +174,7 @@ func newUpCmd(opts *Options) *cobra.Command {
 						sshSummary = "degraded (sshd not ready)"
 					}
 					alias := sshHostAlias(sn)
-					if _, cfgErr := ensureSSHConfigEntry(alias, sn, ns, cfg.Spec.SSH.User, effectiveSSHPort, keyPath, cfgPath, cfg.Spec.Ports, cfg.Spec.SSH); cfgErr != nil {
+					if _, cfgErr := ensureSSHConfigEntry(alias, sn, ns, cfg.Spec.SSH.User, effectiveSSHPort, keyPath, cfgPath, cfg.Spec.Ports); cfgErr != nil {
 						ui.warnf("failed to update ~/.ssh/config: %v", cfgErr)
 						sshSummary = "degraded (ssh config update failed)"
 					} else {