SK-246 // transform trace on export via a SKEL file#252
Open
ogorman89 wants to merge 6 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #252 +/- ##
==========================================
- Coverage 78.37% 77.95% -0.42%
==========================================
Files 62 63 +1
Lines 3852 3883 +31
==========================================
+ Hits 3019 3027 +8
- Misses 833 856 +23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ogorman89
commented
May 26, 2026
| @@ -42,7 +42,12 @@ pub async fn cmd(args: &Args) -> EmptyResult { | |||
| let filters = ExportFilters::new(args.excluded_namespaces.clone(), vec![]); | |||
Contributor
Author
There was a problem hiding this comment.
should snapshot have the same --transform option as export?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description and Rationale
feat: transform trace on export via a SKEL file
How
--transform <file.skel>exportcommand to apply the SKEL transformationprocess_traceandapply_skelfunctionality I moved them out ofsk-storeand intosk-core, this reorganization makes the number of file changes in this PR quite large (apologies)apply_skelto take a SKEL string (instead of a SKEL file path), primarily this change is to support easily passing the SKEL transformation to the tracer.Test Steps
Other Notes
followups & questions:
snapshot?skctl transform?[ X ] I certify that this PR does not contain any code that has been generated with GitHub Copilot or any other AI-based code generation tool, in accordance with this project's policies.