Merge branch 'develop' into rule-2ee8b8-may-2023

Author: Jym77

.github/ISSUE_TEMPLATE/rules-issue-template.md

@@ -4,7 +4,9 @@ about: issues related with ACT Rules
 title: ''
 labels: ''
 assignees: ''
----Please describe the issue with references and relevant examples where necessary.
+---
+
+Please describe the issue with references and relevant examples where necessary.
 
 --- or ---
 

.github/PULL_REQUEST_TEMPLATE.md

@@ -27,6 +27,7 @@ This will require a 2 weeks Call for Review << new rule, or substantial changes
 - [ ] Add label to indicate if it's a `Rule`, `Definition` or `Chore`.
 - [ ] [Link the PR to any issue it solves](https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue). This will be done automatically by [referencing the issue](https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword) at the top of this comment in the indicated place.
 - [ ] Optionally request feedback from anyone in particular by assigning them as "Reviewers".
+- [ ] If your PR is for a new rule with an Accessibility Support note, or for updating the Accessibility Support note of an existing section, make sure to open a corresponding Accessibility Support issue.
 
 ### **When merging a PR:**
 

.github/workflows/wai-deploy.yml

@@ -21,11 +21,8 @@ jobs:
           restore-keys: |
             ${{ runner.os }}-node-
       - run: git config --global url."https://github.com/".insteadOf ssh://git@github.com/
-      - name: Install dependencies
-        run: npm ci
-      # Since we control this we can safely just always use the latest
-      - name: Install act-tools latest
-        run: npm install github:act-rules/act-tools#main
+      - name: Install dependencies (including act-tools dev dependencies)
+        run: npm i --include=dev
       - name: Configure git
         run: |
           git config --global url."https://${{ secrets.WAI_GIT_NAME }}:${{ secrets.WAI_GIT_ACCESS_TOKEN }}@github.com".insteadOf "https://github.com"

__tests__/spelling-ignore.yml

@@ -10,6 +10,8 @@
 - https
 - wai-aria
 - validator
+- w3c
+- wcag-act-rules
 
 # Tag(s)
 - svg # `aria-query` dom tags does not list `svg`

_rules/heading-descriptive-b49b2e.md

@@ -40,11 +40,13 @@ Each target element describes the topic or purpose of the first [perceivable con
 
 Headings that are visible but not in the accessibility tree are a failure of [Success Criterion 1.3.1 Info and Relationships][sc131]. These are not tested by this rule but they can still fail [Success Criterion 2.4.6 Headings and Labels][sc246].
 
+Testing tools treat empty headings `<h1></h1>` or `div role="heading" aria-level="1"></div>` differently. Some fail empty headings under 1.3.1, others under 2.4.6, while others pass these headings because they are ignored by most assistive technologies causing no accessibility barriers at all. This rule doesn't include examples of empty headings because there is currently no harmonized approach for testing them.
+
 ### Assumptions
 
-This rule assumes that the [flat tree][] order is close to the reading order as elements are rendered on the page. Due to positioning, it is possible to render a document in an order that greatly differs from the tree order, in which case the content which is visually associated with a heading might not be the content following it in tree order and this rule might fail while [Success Criterion 2.4.6 Headings and Label][sc246] is still satisfied.
+This rule assumes that the [flat tree][] order is close to the reading order as elements are rendered on the page. Due to positioning, it is possible to render a document in an order that greatly differs from the tree order, in which case the content which is visually associated with a heading might not be the content following it in tree order and this rule might fail while [Success Criterion 2.4.6 Headings and Labels][sc246] is still satisfied.
 
-This rule also assumes that the content the heading is intended to describe is [visible][] and not hidden from assistive technologies. Otherwise, cases such as expandable content using a heading might fail this rule while [Success Criterion 2.4.6 Headings and Label][sc246] is still satisfied.
+This rule also assumes that the content the heading is intended to describe is [visible][] and not hidden from assistive technologies. Otherwise, cases such as expandable content using a heading might fail this rule while [Success Criterion 2.4.6 Headings and Labels][sc246] is still satisfied.
 
 ### Accessibility Support
 
@@ -215,26 +217,6 @@ This `h1` heading element is not [included in the accessibility tree][].
 </html>
 ```
 
-#### Inapplicable Example 3
-
-This `h1` heading element has an empty [accessible name][].
-
-```html
-<html lang="en">
-	<h1></h1>
-</html>
-```
-
-#### Inapplicable Example 4
-
-Semantic heading has an empty [accessible name][].
-
-```html
-<html lang="en">
-	<p role="heading" aria-level="1"></p>
-</html>
-```
-
 [decorative]: https://www.w3.org/TR/WCAG22/#dfn-pure-decoration 'WCAG definition of Pure decoration'
 [flat tree]: https://drafts.csswg.org/css-scoping/#flat-tree 'Definition of flat tree'
 [included in the accessibility tree]: #included-in-the-accessibility-tree 'Definition of included in the accessibility tree'