Fix typescript errors and consolidate dependencies#56
Merged
Conversation
Jym77
approved these changes
May 12, 2026
Comment on lines
+24
to
+27
| "@types/debug": "^4.1.12", | ||
| "@types/js-yaml": "^4.0.2", | ||
| "@types/jsonld": "^1.5.15", | ||
| "@types/markdown-table": "2.0.0", |
Contributor
There was a problem hiding this comment.
Question: Getting the @types out of devDependencies looks very weird since they should only be needed at build time 🤔 Would that be a symptom of something else being wonky in the setup (e.g. not packaging the correct files, …)? Maybe linked to the fact that act-tools is not properly released (we always load it from the repo).
Not blocking due to that as its minor, but it is maybe something we should look at.
Contributor
Author
|
Agree completely @Jym77 we should probably put some more time to think how we want this act-tools to be consumed by act-rules.github.io even if we decide not to release it. But for now I'd say let's merge this in and unblock the WAI website workflow |
WilcoFiers
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since I am trying to use act-tools as a dev dependency for building the WAI assets, it appears that there are typescript errors that prevent installing the package. The package-lock.json of act-rules.github.io pinned act-tools to an older versions and that is currently generating the wrong assets for the WAI website. Hopefully this resolves the typescript errors and will forwward act-tools to the latest version