Fix additional static analyzer warnings

sebastianrath · sebastianrath · commit 0a6b2bd324b8 · 2026-02-14T09:45:27.000-05:00
diff --git a/nodes/dir-walk@v1.go b/nodes/dir-walk@v1.go
@@ -154,7 +154,7 @@ func walk(root string, opts walkOpts, pattern []string, items map[string]os.File
 		})
 
 	} else {
-		entries, err := os.ReadDir(root)
+		entries, err := os.ReadDir(filepath.Clean(root))
 		if err != nil {
 			return "", core.CreateErr(nil, err, "failed to read directory")
 		}
diff --git a/nodes/run@v1.go b/nodes/run@v1.go
@@ -249,6 +249,8 @@ func runCommand(c *core.ExecutionState, shell string, script *string, args []str
 			curEnvMap["PYTHONIOENCODING"] = "utf-8"
 
 			args = append([]string{scriptPath}, args...)
+		default:
+			return "", 0, core.CreateErr(c, nil, "unsupported shell: %s", shell)
 		}
 		cmd = exec.Command(shell, args...)
 

Original file line number	Diff line number	Diff line change
`@@ -154,7 +154,7 @@ func walk(root string, opts walkOpts, pattern []string, items map[string]os.File`
`154`	`154`	`})`
`155`	`155`
`156`	`156`	`} else {`
`157`		`- entries, err := os.ReadDir(root)`
	`157`	`+ entries, err := os.ReadDir(filepath.Clean(root))`
`158`	`158`	`if err != nil {`
`159`	`159`	`return "", core.CreateErr(nil, err, "failed to read directory")`
`160`	`160`	`}`
Original file line number	Diff line number	Diff line change
`@@ -249,6 +249,8 @@ func runCommand(c core.ExecutionState, shell string, script string, args []str`
`249`	`249`	`curEnvMap["PYTHONIOENCODING"] = "utf-8"`
`250`	`250`
`251`	`251`	`args = append([]string{scriptPath}, args...)`
	`252`	`+ default:`
	`253`	`+ return "", 0, core.CreateErr(c, nil, "unsupported shell: %s", shell)`
`252`	`254`	`}`
`253`	`255`	`cmd = exec.Command(shell, args...)`
`254`	`256`