Make secret actually return a SecretValue object for consistency

sebastianrath · sebastianrath · commit 38d23472f506 · 2026-01-20T23:32:57.000-05:00
It used to return just a plain string due to the potential prefix, but thats misleaing
diff --git a/nodes/secret-get@v1.go b/nodes/secret-get@v1.go
@@ -37,7 +37,9 @@ func (n *SecretNode) OutputValueById(c *core.ExecutionState, outputId core.Outpu
 		return "", nil
 	}
 
-	return fmt.Sprintf("%s%s", prefix, secretValue), nil
+	return core.SecretValue{
+		Secret: fmt.Sprintf("%s%s", prefix, secretValue),
+	}, nil
 }
 
 func init() {

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,9 @@ func (n SecretNode) OutputValueById(c core.ExecutionState, outputId core.Outpu`
`37`	`37`	`return "", nil`
`38`	`38`	`}`
`39`	`39`
`40`		`- return fmt.Sprintf("%s%s", prefix, secretValue), nil`
	`40`	`+ return core.SecretValue{`
	`41`	`+ Secret: fmt.Sprintf("%s%s", prefix, secretValue),`
	`42`	`+ }, nil`
`41`	`43`	`}`
`42`	`44`
`43`	`45`	`func init() {`