Merge pull request #3 from actionforge/core/secret

Add core/secret-set and core/secret-get

Author: sebastianrath

.github/workflows/graphs/build-test-publish.act

@@ -657,28 +657,28 @@ nodes:
     inputs:
       value: actrun-notarization-macos.zip
   - id: secret-v1-red-pineapple-guava
-    type: core/secret@v1
+    type: core/secret-get@v1
     position:
       x: 3620
       y: 2680
     inputs:
       name: APPLE_ID
   - id: secret-v1-monkey-silver-boysenberry
-    type: core/secret@v1
+    type: core/secret-get@v1
     position:
       x: 3620
       y: 2790
     inputs:
       name: APPLE_ID_PASSWORD
   - id: secret-v1-kiwano-pineapple-bear
-    type: core/secret@v1
+    type: core/secret-get@v1
     position:
       x: 2220
       y: 2190
     inputs:
       name: APPLE_TEAM_IDENTITY
   - id: secret-v1-cherry-pear-cranberry
-    type: core/secret@v1
+    type: core/secret-get@v1
     position:
       x: 3620
       y: 2570
@@ -1281,7 +1281,7 @@ nodes:
       substitutes[0]: null
       fmt: '%s.pkg'
   - id: secret-v1-giraffe-snake-tiger
-    type: core/secret@v1
+    type: core/secret-get@v1
     position:
       x: 10050
       y: 3000
@@ -1928,7 +1928,7 @@ nodes:
         description: ''
     label: MacOS CodeSign
   - id: secret-v1-cranberry-watermelon-starfruit
-    type: core/secret@v1
+    type: core/secret-get@v1
     position:
       x: 11090
       y: 2200
@@ -2139,21 +2139,21 @@ nodes:
         description: ''
     label: MacOS Notarization
   - id: secret-v1-persimmon-jackfruit-gold
-    type: core/secret@v1
+    type: core/secret-get@v1
     position:
       x: 11570
       y: 2680
     inputs:
       name: APPLE_ID
   - id: secret-v1-date-cow-shark
-    type: core/secret@v1
+    type: core/secret-get@v1
     position:
       x: 11570
       y: 2790
     inputs:
       name: APPLE_ID_PASSWORD
   - id: secret-v1-watermelon-gray-pineapple
-    type: core/secret@v1
+    type: core/secret-get@v1
     position:
       x: 11570
       y: 2570
@@ -5058,7 +5058,7 @@ nodes:
       x: 13840
       y: 1090
   - id: secret-v1-raspberry-apple-giraffe
-    type: core/secret@v1
+    type: core/secret-get@v1
     position:
       x: 13670
       y: 2340

core/base.go

@@ -353,6 +353,7 @@ type NodeTypeDefinitionBasic struct {
 	Label       string     `yaml:"label,omitempty" json:"label,omitempty" bson:"label,omitempty"`
 	Compact     bool       `yaml:"compact,omitempty" json:"compact,omitempty" bson:"compact,omitempty"`
 	GhMeta      GhMetadata `yaml:"gh_meta" json:"gh_meta" bson:"gh_meta"`
+	Aliases     []string   `yaml:"aliases,omitempty" json:"aliases,omitempty" bson:"aliases,omitempty"`
 
 	// Used by the gateway to indicate errors when being retreived
 	Error string `yaml:"error,omitempty" json:"error,omitempty" bson:"error,omitempty"`
@@ -561,6 +562,17 @@ func RegisterNodeFactory(nodeDefStr string, fn nodeFactoryFunc) error {
 	nodeDef.FactoryFn = fn
 	registries[id] = nodeDef
 
+	for _, alias := range nodeDef.Aliases {
+		if strings.Contains(alias, "_") {
+			return CreateErr(nil, nil, "alias '%v' must not contain underscores", alias)
+		}
+		aliasId := fmt.Sprintf("%v@v%v", alias, nodeDef.Version)
+		if _, exists := registries[aliasId]; exists {
+			return CreateErr(nil, nil, "alias '%v' already registered", aliasId)
+		}
+		registries[aliasId] = nodeDef
+	}
+
 	return nil
 }
 

core/errors.go

@@ -68,7 +68,7 @@ func (e *LeafError) Error() string {
 func (e *LeafError) ErrorWithCauses() string {
 	var lines []string
 
-	// 1. Top level error (no prefix)
+	// top level error (no prefix)
 	// iterate backwards for high-level first
 	for i := len(e.ErrorStack) - 1; i >= 0; i-- {
 		prefix := ""

core/inputs.go

@@ -362,11 +362,12 @@ func (n *Inputs) InputValueById(ec *ExecutionState, host NodeWithInputs, inputId
 
 			ec.PushNodeVisit(dataSource.SrcNode, false)
 			v, err := dataSource.SrcNodeOutputs.OutputValueById(ec, OutputId(outputCacheId))
-			ec.PopNodeVisit()
 			if err != nil {
 				return nil, err
 			}
 
+			ec.PopNodeVisit()
+
 			// handle slice indexing
 			if dataSource.SrcIndexOutputInfo != nil {
 				slice := reflect.ValueOf(v)

node_interfaces/interface_core_random-number_v1.go

@@ -8,7 +8,7 @@ import (
 	ni "github.com/actionforge/actrun-cli/node_interfaces"
 )
 
-//go:embed secret@v1.yml
+//go:embed secret-get@v1.yml
 var secretDefinition string
 
 type SecretNode struct {
@@ -18,12 +18,12 @@ type SecretNode struct {
 }
 
 func (n *SecretNode) OutputValueById(c *core.ExecutionState, outputId core.OutputId) (any, error) {
-	secretName, err := core.InputValueById[string](c, n, ni.Core_secret_v1_Input_name)
+	secretName, err := core.InputValueById[string](c, n, ni.Core_secret_get_v1_Input_name)
 	if err != nil {
 		return nil, err
 	}
 
-	prefix, err := core.InputValueById[string](c, n, ni.Core_secret_v1_Input_prefix)
+	prefix, err := core.InputValueById[string](c, n, ni.Core_secret_get_v1_Input_prefix)
 	if err != nil {
 		return nil, err
 	}

node_interfaces/interface_core_secret-get_v1.go

@@ -1,8 +1,10 @@
 yaml-version: 3.0
 
-id: core/secret
+id: core/secret-get
 version: 1
-name: Secret
+aliases:
+  - core/secret
+name: Get Secret
 icon: octKey
 category: system
 short_desc: A node to read key secrets. 

node_interfaces/interface_core_secret-set_v1.go

@@ -0,0 +1,43 @@
+package nodes
+
+import (
+	_ "embed"
+
+	"github.com/actionforge/actrun-cli/core"
+	ni "github.com/actionforge/actrun-cli/node_interfaces"
+)
+
+//go:embed secret-set@v1.yml
+var setSecretDefinition string
+
+type SetSecretNode struct {
+	core.NodeBaseComponent
+	core.Executions
+	core.Inputs
+	core.Outputs
+}
+
+func (n *SetSecretNode) ExecuteImpl(c *core.ExecutionState, inputId core.InputId, prevError error) error {
+	secretName, err := core.InputValueById[string](c, n, ni.Core_secret_set_v1_Input_name)
+	if err != nil {
+		return err
+	}
+
+	secretValue, err := core.InputValueById[string](c, n, ni.Core_secret_set_v1_Input_value)
+	if err != nil {
+		return err
+	}
+
+	c.Secrets[secretName] = secretValue
+
+	return n.Execute(ni.Core_secret_set_v1_Output_exec_success, c, nil)
+}
+
+func init() {
+	err := core.RegisterNodeFactory(setSecretDefinition, func(ctx any, parent core.NodeBaseInterface, parentId string, nodeDef map[string]any, validate bool) (core.NodeBaseInterface, []error) {
+		return &SetSecretNode{}, nil
+	})
+	if err != nil {
+		panic(err)
+	}
+}