Merge pull request #349 from actions/ncalteen/events

Author: ncalteen

__tests__/main.test.ts

@@ -49,6 +49,7 @@ describe('main.ts', () => {
   describe('run()', () => {
     it('Skips invalid events', async () => {
       github.context.eventName = 'push'
+      github.context.payload = {} as any
 
       await main.run()
 
@@ -73,17 +74,6 @@ describe('main.ts', () => {
       )
     })
 
-    it('Fails if neither PR nor issue are provided', async () => {
-      github.context.payload.issue = undefined as any
-      github.context.payload.pull_request = undefined as any
-
-      await main.run()
-
-      expect(core.setFailed).toHaveBeenCalledWith(
-        'Internal Error...No Issue or PR Provided by GitHub'
-      )
-    })
-
     it('Fails if both PR and issue are provided', async () => {
       github.context.payload.issue = {
         number: 20

dist/index.js

@@ -1,7 +1,7 @@
 {
   "name": "first-interaction-action",
   "description": "An action for greeting first time contributors.",
-  "version": "3.0.0",
+  "version": "3.1.0",
   "author": "GitHub",
   "type": "module",
   "private": true,

dist/index.js.map

@@ -5,11 +5,12 @@ import { Octokit } from '@octokit/rest'
 export async function run() {
   core.info('Running actions/first-interaction!')
 
+  // Check if this is an issue or PR event.
+  const isIssue = github.context.payload.issue !== undefined
+  const isPullRequest = github.context.payload.pull_request !== undefined
+
   // Skip if this is not an issue or PR event.
-  if (
-    github.context.eventName !== 'issues' &&
-    github.context.eventName !== 'pull_request'
-  )
+  if (!isIssue && !isPullRequest)
     return core.info('Skipping...Not an Issue/PR Event')
 
   // Skip if this is not an issue/PR open event.
@@ -20,13 +21,7 @@ export async function run() {
   if (!github.context.payload.sender)
     return core.setFailed('Internal Error...No Sender Provided by GitHub')
 
-  // Check if this is an issue or PR event.
-  const isIssue = github.context.payload.issue !== undefined
-  const isPullRequest = github.context.payload.pull_request !== undefined
-
   // Confirm that only one of the two is present.
-  if (!isIssue && !isPullRequest)
-    return core.setFailed('Internal Error...No Issue or PR Provided by GitHub')
   if (isIssue && isPullRequest)
     return core.setFailed(
       'Internal Error...Both Issue and PR Provided by GitHub'