Skip to content

Tags starting with v are not valid semantic versions #225

@justinmchase

Description

@justinmchase

Your documentation says:

The associated tag must follow semantic versioning - this tag value will be used to create a package version.

Consumers of your action will then be able to specify that version to consume your action from the package, e.g.

  • uses: your-name/your-action@v1.2.3
  • uses: your-name/your-action@v1

But v1.2.3 and v1 are not valid semantic versions, 1.2.3 is however.

This may seem like pedantry and also I am aware of the limitation of github being unable to resolve the tag 1 and therefore you need something like v1 for it to be a valid tag, however I'd just like to say it seems like a mistake to support partial versions and invalid semantic versions and instead you should support only valid semantic versions.

Also, instead of v1 you should support semver ranges.

examples

- uses: your-name/your-action@1.2.3
- uses: your-name/your-action@^1.2.3

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions