Fix handling of :document shorthand in OpenAI Chat transforms (PDF Attachements)#332
Merged
TonsOfFun merged 1 commit intoMay 7, 2026
Conversation
The normalize_message method in OpenAI Chat transforms handled :image
shorthand but not :document. When { document: "data:..." } was passed,
the document data was silently dropped and leaked as an extra param.
Changes:
- Add :document handling with URL and data URI support
- Add :document to extra_params.except() to prevent leaking
- Add build_file_content helper for file content blocks
- Add 4 tests covering document shorthand scenarios
Fixes activeagents#331
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The normalize_message method in OpenAI Chat transforms handled :image shorthand but not :document. When { document: "data:..." } was passed, the document data was silently dropped and leaked as an extra param.
Changes:
Fixes #331