Skip to content

Fix deprecation warning and correctness bug when using arel_extensions >= 2.2 #1679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
javieromar7 wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

Fix deprecation warning and correctness bug when using arel_extensions >= 2.2 #1679

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/ransack/adapters/active_record/context.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,9 +212,9 @@ def extract_correlated_key(join_root)
end
when Arel::Nodes::Equality
pk = primary_key
if join_root.left == pk
if join_root.left.eql?(pk)
join_root.right
elsif join_root.right == pk
elsif join_root.right.eql?(pk)
join_root.left
else
nil
Expand Down