fix: svg files should be compressed#3486
Merged
Merged
Conversation
Contributor
Author
|
Not really sure about the 'Linux / msrv actix-files tests::test_head_content_length_headers' test failure, because afaict I didn't touch anything that could cause that test to fail. About the 'public-api-diff' I saw that another PR was failing with the same error message as this PR: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Bug Fix
PR Checklist
Tests for the changes have been added / updated.Documentation comments have been added / updated.Overview
#3075 removed compression for image & video files, because they usually come pre-compressed.
SVG (image/svg+xml) files are exceptions (IMO), because they're text based, so they could benefit from being served as compressed assets.
Note 1: I wasn't sure whether to add a test or not.
Note 2: I wasn't able to test this change because I was getting a wall of seemingly unrelated 'unresolved imports' errors in my project after switching to my fork in the Cargo.toml.