Lower Linux glibc floor to 2.28#2828
Open
plajjan wants to merge 1 commit into
Open
Conversation
Target glibc 2.28 instead of 2.31 so released Linux binaries run on OracleLinux 8 / RHEL 8 (and Debian 10, Ubuntu 18.04+). 2.28 was Acton's historical floor; the 2.31 bump was only to match the Debian 11 release host and was never a hard promise. The floor is set through Zig's -target <arch>-linux-gnu.2.28, so it is independent of the build host's glibc. The existing `make ldd` check fails the build if acton, lsp-server-acton, or actondb require a GLIBC symbol newer than the target, so the ceiling stays enforced.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Target glibc 2.28 instead of 2.31 so released Linux binaries run on OracleLinux 8 / RHEL 8 (and Debian 10, Ubuntu 18.04+). 2.28 was Acton's historical floor; the 2.31 bump was only to match the Debian 11 release host and was never a hard promise.
The floor is set through Zig's -target -linux-gnu.2.28, so it is independent of the build host's glibc. The existing
make lddcheck fails the build if acton, lsp-server-acton, or actondb require a GLIBC symbol newer than the target, so the ceiling stays enforced.