Skip to content

Build dist/std before make test #2857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
plajjan wants to merge 1 commit into from
Closed

Build dist/std before make test #2857

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,18 +506,18 @@ dist/deps/libyyjson: deps/libyyjson $(DIST_ZIG)
cp -a "$</"* "$(TD)/$@"

# top level targets
.PHONY: test test-builtins test-compiler test-db test-examples test-lang test-regressions test-rts test-stdlib online-tests
.PHONY: test test-builtins test-compiler test-db test-examples test-lang test-regressions test-rts test-stdlib test-stdlib-run online-tests
.PHONY: test-compiler-accept test-lib-accept test-acton-goldens-accept test-goldens-accept
# These run stack against libacton/acton, which link liblmdb, so the bdeps
# archives must exist first. (test, test-stdlib, test-incremental, online-tests
# already pull it in transitively via dist/bin/acton[c].)
test-builtins test-compiler test-lib-accept test-acton-goldens-accept test-cross-compile test-syntaxerrors test-syntaxerrors-accept test-typeerrors test-typeerrors-accept test-db test-examples test-lang test-regressions test-rts: $(BDEPS)
test: dist/bin/acton
test: dist/bin/acton dist/std
cd compiler && stack test libacton acton:incremental
# Exclude the cross-compilation group from the default run: it builds for
# many targets and bloats ~/.cache/acton. Run it via `make test-cross-compile`.
cd compiler && stack test acton:test_acton --ta '-p "! /cross-compilation/"'
$(MAKE) test-stdlib
$(MAKE) test-stdlib-run
$(MAKE) -C backend test
$(MAKE) test-rts-db

Expand Down Expand Up @@ -583,7 +583,9 @@ test-rts:
test-rts-db:
$(MAKE) -C test

test-stdlib: dist/bin/acton dist/std
test-stdlib: dist/bin/acton dist/std test-stdlib-run
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot Jun 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep stdlib tests ordered after dist/std

When make -j test-stdlib is used, test-stdlib-run is just another independent prerequisite of test-stdlib, so GNU make may start it before dist/std finishes (make --help documents -j as allowing multiple jobs at once). That reintroduces the same missing/preparing dist/std race for the documented standalone stdlib target; make the run step a recipe after the prerequisites instead of a parallelizable prerequisite.

Useful? React with 👍 / 👎.


test-stdlib-run:
cd compiler && stack test acton --ta '-p "stdlib"'
$(MAKE) -C test tls-test-server
cd test/stdlib_tests && "$(ACTON)" test
Expand Down