Skip to content

Skip final build in DBP fixture test #2861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
plajjan wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Skip final build in DBP fixture test #2861

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion compiler/acton/test.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -505,7 +505,7 @@ compilerTests =
removeIfExists (typesDir </> "main.h")
removeIfExists (typesDir </> "main.root.c")
sixthLog <- assertOk "dbp keeps executable root actor" =<<
runBuild ["build", "--verbose", "--dbp", "main", "--dbp", "provider", "--color", "never"]
runBuild ["build", "--skip-build", "--verbose", "--dbp", "main", "--dbp", "provider", "--color", "never"]
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot Jun 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Restore the DBP root build coverage

Adding --skip-build here means this subcase no longer regenerates main.root.c after the test deletes it above, because skip_build returns before zigBuild, and writeRootC is only called from zigBuild in compiler/acton/Main.hs. This lets the test pass while the DBP executable-root path is unable to produce/link an executable root stub; the main.c assertion only proves the actor body was emitted, not that acton build --dbp main can still build the binary entry point.

Useful? React with 👍 / 👎.

assertBool "root module should report root seed" ("DBP main: forced by --dbp" `isInfixOf` sixthLog)
assertBool "root module should count root name" ("root names 1" `isInfixOf` sixthLog)
mainC <- readFile (typesDir </> "main.c")
Expand Down
Loading