Skip perf mode for downstream app tests#2862
Closed
plajjan wants to merge 1 commit into
Closed
Conversation
Downstream app checks are compatibility gates: build the app and run its normal tests. Running perf mode repeats every test under a timeout-sensitive benchmark loop. That made orchestron fail after the normal suite already passed. Keep performance coverage in the dedicated perf-vs-main job.
plajjan
force-pushed
the
skip-test-app-perf
branch
from
1eea326 to
c2e163c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Downstream app checks already build each app and run the normal test suite. Running
acton test perfthere turns the compatibility gate into a benchmark-style loop for every downstream app, and we have seen orchestron pass normal tests but fail in perf mode on a timeout-sensitive test.This keeps downstream app checks focused on build and correctness. The existing perf-vs-main job remains responsible for Acton's own perf comparison path.