Prepare ActonDB before DB tests#2863
Open
plajjan wants to merge 1 commit into
Open
Conversation
The local DB test target compiles programs with --db. That makes base link the ActonDB artifact through the dist/backend package. Make test-rts-db depend on dist/bin/actondb. Make that binary target prepare the copied backend package before invoking Zig.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DB tests compile programs with
--db, so base needs the ActonDB artifact from the copieddist/backendpackage. The defaultmake testpath could reach those tests after only copyingdist/backend/Build.act, which leaves Zig with a dependency package that has noActonDBartifact.This makes the DB test target prepare
dist/bin/actondb, and makes that binary target copy the backend package before invoking Zig.