Skip final build in stale path dep setup#2868
Closed
plajjan wants to merge 1 commit into
Closed
Conversation
The stale path dependency fixture needs the final Zig build only for the app build that checks stale dependency outputs are ignored. Use --skip-build for the initial dependency build that only creates the stale C output. Keep the app build as a full build so the test still covers the final-build behavior it was added for.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The stale path dependency fixture only needs the first dependency build to leave behind the stale generated C output. The final Zig build is still needed for the app build, where the test verifies that stale dependency outputs are ignored.
This splits the helper so the setup dependency build uses --skip-build while the app build remains a full build. That keeps the behavioral coverage intact and avoids one expensive final build in a consistently slow test.