Skip to content

Skip final build in stale path dep setup #2868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
plajjan wants to merge 1 commit into from
Closed

Skip final build in stale path dep setup #2868

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions compiler/acton/test.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -786,8 +786,10 @@ compilerTests =
, "zig_dependencies = {}"
, ""
]
runBuild dir = readCreateProcessWithExitCode
(proc actonExe ["build", "--always-build"]) { cwd = Just dir, env = Just envWithHome } ""
runBuild args dir = readCreateProcessWithExitCode
(proc actonExe args) { cwd = Just dir, env = Just envWithHome } ""
runBuildFull = runBuild ["build", "--always-build"]
runBuildSkipFinal = runBuild ["build", "--always-build", "--skip-build"]
assertBuildOk label (code, out, err) =
when (code /= ExitSuccess) $
assertFailure (label ++ " failed:\nstdout:\n" ++ out ++ "\nstderr:\n" ++ err)
Expand Down Expand Up @@ -833,10 +835,10 @@ compilerTests =
, " env.exit(0)"
]

assertBuildOk "initial build of mid dependency" =<< runBuild midProj
assertBuildOk "initial build of mid dependency" =<< runBuildSkipFinal midProj
staleCExists <- doesFileExist (midProj </> "out" </> "types" </> "mid" </> "stale.c")
assertBool "expected stale dependency C output to exist" staleCExists
assertBuildOk "build of app with transitive dep override" =<< runBuild appProj
assertBuildOk "build of app with transitive dep override" =<< runBuildFull appProj
, testCase "build.zig.zon name matches Build.act" $ do
let prefix = "acton-long-project-name-12345678901234567890-"
withSystemTempDirectory prefix $ \proj -> do
Expand Down