Test snapshot cache invalidation directly#2869
Closed
plajjan wants to merge 1 commit into
Closed
Conversation
The previous fixture launched acton test three times to check one cache metadata rule, making the compiler test suite pay for full project builds. Cover that rule by calling the snapshot cache filter with temporary expected and output files. Existing acton test integration coverage still exercises the build and runner path, while this test keeps the invalidation case focused on the timestamp and size check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The snapshot cache invalidation test used to shell out to
acton testthree times to check one metadata rule. That made the compiler test suite pay for full project builds even though the behavior under test is whether cached snapshot output can still be trusted.This calls the snapshot cache filter directly with temporary expected and output files. The test still checks both sides of the rule: unchanged snapshots keep the cached result, while a changed expected snapshot forces a rerun. Existing
acton testintegration coverage continues to exercise the build and runner path.