Skip to content

Run one macOS source test on PRs #2873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
plajjan wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Run one macOS source test on PRs #2873

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,10 +90,18 @@ jobs:
outputs:
matrix: ${{ steps.setmatrix.outputs.matrix }}
steps:
- name: "Set Matrix for PR or push"
# Keep PR matrix minimal; extra entries increase cache pressure and slow PR workflows.
if: github.event_name != 'schedule' && github.event_name != 'workflow_dispatch'
- name: "Set Matrix for PR"
# Keep PR matrix minimal; full macOS coverage still runs on main, tags,
# scheduled runs, and manual runs.
if: github.event_name == 'pull_request'
id: setmatrix_pr
run: |
MATRIX_JSON='{\"include\":[{\"os\":\"macos\",\"version\":\"15\",\"arch\":\"aarch64\",\"cache\":true}]}'
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot Jun 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep producing the x86 macOS artifact for PR smoke tests

On pull_request events this matrix now only builds macos-15/aarch64, but run-macos still includes macos-15-intel and its download step requests acton-macos-15-x86_64 (.github/workflows/test.yml:533-554). Since that artifact is no longer uploaded by test-macos on PRs, the Intel smoke-test job will fail at actions/download-artifact before it can run, making PR workflows fail. Either keep the x86_64 producer for PRs or also gate/prune the downstream run-macos matrix for PRs.

Useful? React with 👍 / 👎.

echo "matrix=$MATRIX_JSON" >> $GITHUB_OUTPUT

- name: "Set Matrix for push"
if: github.event_name == 'push'
id: setmatrix_push
run: |
MATRIX_JSON='{\"include\":[{\"os\":\"macos\",\"version\":\"15\",\"arch\":\"aarch64\",\"cache\":true},{\"os\":\"macos\",\"version\":\"15\",\"arch\":\"x86_64\",\"cache\":true},{\"os\":\"macos\",\"version\":\"26\",\"arch\":\"aarch64\",\"cache\":true}]}'
echo "matrix=$MATRIX_JSON" >> $GITHUB_OUTPUT
Expand All @@ -108,10 +116,12 @@ jobs:
- name: "Set final matrix output"
id: setmatrix
run: |
if [ "${{ github.event_name }}" == "schedule" ] || [ "${{ github.event_name }}" == "workflow_dispatch" ]; then
if [ "${{ github.event_name }}" == "pull_request" ]; then
echo "matrix=${{ steps.setmatrix_pr.outputs.matrix }}" >> $GITHUB_OUTPUT
elif [ "${{ github.event_name }}" == "schedule" ] || [ "${{ github.event_name }}" == "workflow_dispatch" ]; then
echo "matrix=${{ steps.setmatrix_cron.outputs.matrix }}" >> $GITHUB_OUTPUT
else
echo "matrix=${{ steps.setmatrix_pr.outputs.matrix }}" >> $GITHUB_OUTPUT
echo "matrix=${{ steps.setmatrix_push.outputs.matrix }}" >> $GITHUB_OUTPUT
fi

- name: "Debug: Print matrix JSON"
Expand Down
Loading