Run one Linux package smoke on PRs#2874
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 696e275068
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if: github.event_name == 'pull_request' | ||
| id: setmatrix_pr | ||
| run: | | ||
| MATRIX_JSON='{\"include\":[{\"os\":\"debian\",\"version\":\"11\",\"arch\":\"amd64\"}]}' |
There was a problem hiding this comment.
Emit unescaped JSON for the dynamic matrix
In the checked workflow shell snippet, this assignment writes literal backslashes to $GITHUB_OUTPUT ({\"include\":...}), so the later fromJson(needs.matrix_maker_run_linux.outputs.matrix) receives invalid JSON and run-linux cannot expand on PRs. The full-run matrix below uses the same escaping, so pushes/tags/schedules/manual runs are affected as well; the output should be raw JSON such as {"include":[...]} without the backslashes before quotes.
Useful? React with 👍 / 👎.
Pull request runs currently enqueue the full Linux package smoke matrix after the Debian packages are built. Those checks are useful release coverage, but on PRs they add eight short runner jobs after the source tests and downstream app jobs already exercise the compiler and packaged install path.
This keeps one Debian 11 amd64 package smoke in the PR loop, which preserves the oldest Linux runtime/package floor there, and leaves the full distro, arm, and musl smoke matrix on main pushes, tag pushes, scheduled runs, and manual runs.