Use persistent scratch in REPL tests#2881
Merged
Merged
Conversation
REPL command tests were forcing a fresh --tempdir for nearly every case. Each test built a separate dynamic-library scratch project instead of exercising normal REPL reuse. Keep renderer assertions in-process, run the REPL group serially, and let command tests use the regular persistent scratch path. The only remaining --tempdir coverage is the test for explicit tempdir isolation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
REPL tests were using --tempdir for almost every command-level case. That made each case build a fresh scratch project and pay the dynamic-library setup cost over and over, which is not how the REPL normally runs.
This keeps source rendering checks in-process through the REPL renderer, runs the REPL test group serially, and lets command-level tests use the persistent scratch path. The explicit --tempdir test remains, but only for checking that an explicit tempdir writes inside .acton-repl and does not clobber the parent project.
The command coverage still exercises retained definitions, replayed setup, reset behavior, failed setup rejection, and process reuse. It just stops forcing a new scratch root for every assertion that does not need one.