Add N-API subproject to run node-semver test eventually#13
Conversation
anonrig
left a comment
anonrig
left a comment
There was a problem hiding this comment.
Amazing work! Can you add a github workflow and actually have it run on the CI?
| @@ -0,0 +1,15 @@ | |||
| { | |||
There was a problem hiding this comment.
Can we add package-lock and use npm? Yarn might be hard to maintain in the long term.
|
Can you also run the shell script in tools folder to format the code using clang-format-17 |
lemire
left a comment
lemire
left a comment
There was a problem hiding this comment.
I can't object to have this repository added.
|
I'm not sure why I can't seem to make it work on Linux CI, but at least it should tell us if a node-semver test starts failing/passing |
|
hey @aduh95, any plans to continue working on version_weaver? |
|
I mean, the project still sounds interesting, but it's just hard to find time for it now that I have a job |
|
I would like to help here |
|
@mertcanaltin Do you want to pick up the PR and work on it ? I think it would be fine with @aduh95. |
That'd be great, I'll do that. |
4 participants
The idea is that we could eventually run the node-semver test suite.
Use the following commands to build: