Skip to content

Changed order of NeoPixel lighting#3243

Open
daletan wants to merge 1 commit into
adafruit:mainfrom
daletan:EspressoWaterMeter-PixelFix
Open

Changed order of NeoPixel lighting#3243
daletan wants to merge 1 commit into
adafruit:mainfrom
daletan:EspressoWaterMeter-PixelFix

Conversation

@daletan
Copy link
Copy Markdown

@daletan daletan commented May 16, 2026

NeoPixel currently holds on to cyan or pink color after the connection test, instead of indicating water level in the test. I moved the NeoPixel color display down, so that the water level status color would be the one that holds (after the connection test color, of course)

Thank you for creating a pull request to contribute to Adafruit's GitHub code!
Before you open the request please review the following guidelines and tips to
help it be more easily integrated:

  • **Describe the scope of your change-- Just moved the line down past the Wifi connection test.

  • Describe any known limitations with your change. For example if the change
    doesn't apply to a supported platform of the library please mention it. - N/A

  • Please run any tests or examples that can exercise your modified code. We
    strive to not break users of the code and running tests/examples helps with this
    process. -- Tested against my own espresso water meter setup :)

Thank you again for contributing! We will try to test and integrate the change
as soon as we can, but be aware we have many GitHub repositories to manage and
can't immediately respond to every request. There is no need to bump or check in
on a pull request (it will clutter the discussion of the request).

Also don't be worried if the request is closed or not integrated--sometimes the
priorities of Adafruit's GitHub code (education, ease of use) might not match the
priorities of the pull request. Don't fret, the open source community thrives on
forks and GitHub makes it easy to keep your changes in a forked repo.

After reviewing the guidelines above you can delete this text from the pull request.

NeoPixel currently holds on to cyan or pink color after the connection test, instead of indicating water level in the test. I moved the NeoPixel color display down, so that the water level status color would be the one that holds (after the connection test color, of course)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant