Fix for hold-to-save#3252
Merged
Merged
Conversation
Fix hold-to-save: time the hold from the debounced level, not edge flags The Button.pressed/released one-shot edge flags intermittently dropped a press, so hold-to-save would fall through and register as a short tap (switching mode instead of saving). poll_button now reads the debounced level (button.value) and detects the press/release edges itself, timing the hold with time.monotonic(). This also survives the ~300-500 ms loop stall from the blocking 1 Hz GPS read, which the library's internal hold timer could not. The debouncer is still used for noise filtering.
Contributor
Author
|
@BlitzCityDIY @TheKitty Pushed a fix for hold-to-save. While demoing I found the button hold had stopped saving waypoints; a quick tap would switch mode, but a long hold also just switched mode instead of opening the name picker. |
BlitzCityDIY
requested changes
Jun 24, 2026
Collaborator
There was a problem hiding this comment.
can you revert code.py and mc_config.py? it looks like no code changed, just file mode
BlitzCityDIY
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix hold-to-save: time the hold from the debounced level, not edge flags
The Button.pressed/released one-shot edge flags intermittently dropped a press, so hold-to-save would fall through and register as a short tap (switching mode instead of saving). poll_button now reads the debounced level (button.value) and detects the press/release edges itself, timing the hold with time.monotonic(). This also survives the ~300-500 ms loop stall from the blocking 1 Hz GPS read, which the library's internal hold timer could not. The debouncer is still used for noise filtering.