DO NOT MERGE: Supports setting PHY for extended range#223
Draft
mharper wants to merge 1 commit into
Draft
Conversation
Adds `setPhy`/`getPhy` for setting PHY. On nRF52840, allows setting PHY to `BLE_GAP_PHY_CODED` to support extended range. This work compiles but is not yet field-tested.
Member
|
thanks for your addition. I remembered we need to handle PHY event, and response to PHY request etc.. but this is a good start. |
|
@mharper did you field-tested it yet? Did it work? |
Contributor
Author
|
Not yet. Being able to crank up the tx power to +8dBm obviated the immediate need for extended range in my project. |
|
Just curious, is there going to be support for this? |
Member
|
There is, question is when since there is tons of other pending issues 😅😅 |
Member
|
|
Merged
Member
|
reopen since it is closed by mistake |
|
Is it possible to switch to coded PHY now? |
|
Is Coded PHY possible now? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
setPhy/getPhyfor setting PHY. On nRF52840, allows setting PHYto
BLE_GAP_PHY_CODEDto support extended range.This work compiles but is not yet field-tested.
Implements #82.