Adds feature reports support on Bluefruit52Lib's BLEHidGeneric service#849
Merged
hathach merged 2 commits intoMay 6, 2026
Merged
Conversation
hathach
reviewed
Mar 18, 2026
| { | ||
| _chr_features[i].setUuid(UUID16_CHR_REPORT); | ||
| _chr_features[i].setProperties(CHR_PROPS_READ | CHR_PROPS_WRITE | CHR_PROPS_WRITE_WO_RESP); | ||
| _chr_features[i].setPermission(SECMODE_OPEN, SECMODE_OPEN); |
Member
There was a problem hiding this comment.
permission is too open, should we use SECMODE_ENC_NO_MITM, SECMODE_ENC_NO_MITM as the same as output report ?
hathach
approved these changes
May 6, 2026
Member
hathach
left a comment
hathach
left a comment
There was a problem hiding this comment.
look good, thank you. I update the permission to match other hid chars.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BLE HID Input and output reports are working fine but support for feature reports is missing from this lib.
WebHID Explorer offers a great tool for testing feature reports. In order to get feature reports working with the Seeed XIAO nrf Sense board, I needed to patch these changes into the platform.io framework used.