stop blink timer in autoConnLed(false)#865
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Bluefruit52 library’s connection LED control so disabling the auto connection LED also stops the underlying blink timer, preventing continued LED toggling/background timer activity when the feature is turned off.
Changes:
- Modify
AdafruitBluefruit::autoConnLed(bool enabled)to stop the LED blink timer whenenabled == false. - Reformat the
autoConnLeddefinition (brace placement changed).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
|
|
||
| void AdafruitBluefruit::autoConnLed(bool enabled) | ||
| { | ||
| void AdafruitBluefruit::autoConnLed(bool enabled) { |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
better fix for #862 since there is no callback wasting cpu cycle