From ec0a415838e7a8ea8be987abf0a048b13bd628f3 Mon Sep 17 00:00:00 2001 From: hathach Date: Wed, 18 Mar 2026 18:41:36 +0700 Subject: [PATCH 1/2] stop blink timer in autoConnLed(false) --- libraries/Bluefruit52Lib/src/bluefruit.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libraries/Bluefruit52Lib/src/bluefruit.cpp b/libraries/Bluefruit52Lib/src/bluefruit.cpp index 9a91dc5b8..89ad50f1c 100644 --- a/libraries/Bluefruit52Lib/src/bluefruit.cpp +++ b/libraries/Bluefruit52Lib/src/bluefruit.cpp @@ -561,9 +561,11 @@ int8_t AdafruitBluefruit::getTxPower(void) return _tx_power; } -void AdafruitBluefruit::autoConnLed(bool enabled) -{ +void AdafruitBluefruit::autoConnLed(bool enabled) { _led_conn = enabled; + if (!enabled) { + xTimerStop(_led_blink_th, 0); + } } void AdafruitBluefruit::setConnLedInterval(uint32_t ms) From 0e6562df6ed3e14f126186c13f055be13b78bec2 Mon Sep 17 00:00:00 2001 From: Ha Thach Date: Wed, 18 Mar 2026 18:51:18 +0700 Subject: [PATCH 2/2] Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --- libraries/Bluefruit52Lib/src/bluefruit.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libraries/Bluefruit52Lib/src/bluefruit.cpp b/libraries/Bluefruit52Lib/src/bluefruit.cpp index 89ad50f1c..09e1252a4 100644 --- a/libraries/Bluefruit52Lib/src/bluefruit.cpp +++ b/libraries/Bluefruit52Lib/src/bluefruit.cpp @@ -563,13 +563,16 @@ int8_t AdafruitBluefruit::getTxPower(void) void AdafruitBluefruit::autoConnLed(bool enabled) { _led_conn = enabled; - if (!enabled) { + if (!enabled && _led_blink_th != NULL) { xTimerStop(_led_blink_th, 0); } } void AdafruitBluefruit::setConnLedInterval(uint32_t ms) { + // Timer is created in begin(); if called earlier, just ignore. + if (_led_blink_th == NULL) return; + BaseType_t active = xTimerIsTimerActive(_led_blink_th); xTimerChangePeriod(_led_blink_th, ms2tick(ms), 0);