ports/stm: reuse existing translations and shared deinit guard in audioio

Address review feedback on PR #10976:

- Replace 11 audioio-specific MP_ERROR_TEXT strings with existing pot
  entries via %q substitution (Invalid %q pin, %q init failed) or by
  reusing analogio/AnalogOut's "DAC Device/Channel Init Error".
- Drop the redundant in-driver deinit check in
  common_hal_audioio_audioout_play(); the shared-bindings layer already
  guards every entry point with check_for_deinit -> raise_deinited_error.
- Net result: zero new entries in locale/circuitpython.pot.
- Also remove tests/circuitpython-manual/audioio/results.md (committed
  in a prior commit; the test scripts stay, the captured run output
  shouldn't live in the repo).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Author: Chris Nourse

locale/circuitpython.pot

@@ -140,6 +140,7 @@ msgid "%q indices must be integers, not %s"
 msgstr ""
 
 #: ports/analog/common-hal/busio/SPI.c ports/analog/common-hal/busio/UART.c
+#: ports/stm/common-hal/audioio/AudioOut.c
 #: shared-bindings/digitalio/DigitalInOutProtocol.c
 #: shared-module/busdisplay/BusDisplay.c
 msgid "%q init failed"
@@ -630,18 +631,6 @@ msgstr ""
 msgid "Audio source error"
 msgstr ""
 
-#: ports/stm/common-hal/audioio/AudioOut.c
-msgid "AudioOut is deinited"
-msgstr ""
-
-#: ports/stm/common-hal/audioio/AudioOut.c
-msgid "AudioOut requires pin A0 (PA04)"
-msgstr ""
-
-#: ports/stm/common-hal/audioio/AudioOut.c
-msgid "AudioOut right channel requires pin A1 (PA05)"
-msgstr ""
-
 #: shared-bindings/wifi/Radio.c
 msgid "AuthMode.OPEN is not used with password"
 msgstr ""
@@ -901,41 +890,19 @@ msgid "Critical ROS failure during soft reboot, reset required: %d"
 msgstr ""
 
 #: ports/stm/common-hal/analogio/AnalogOut.c
-msgid "DAC Channel Init Error"
-msgstr ""
-
 #: ports/stm/common-hal/audioio/AudioOut.c
-msgid "DAC DMA start failed"
-msgstr ""
-
-#: ports/stm/common-hal/audioio/AudioOut.c
-msgid "DAC DMA start failed (right channel)"
+msgid "DAC Channel Init Error"
 msgstr ""
 
 #: ports/stm/common-hal/analogio/AnalogOut.c
+#: ports/stm/common-hal/audioio/AudioOut.c
 msgid "DAC Device Init Error"
 msgstr ""
 
 #: ports/atmel-samd/common-hal/audioio/AudioOut.c
 msgid "DAC already in use"
 msgstr ""
 
-#: ports/stm/common-hal/audioio/AudioOut.c
-msgid "DAC channel config error"
-msgstr ""
-
-#: ports/stm/common-hal/audioio/AudioOut.c
-msgid "DAC init error"
-msgstr ""
-
-#: ports/stm/common-hal/audioio/AudioOut.c
-msgid "DMA init failed"
-msgstr ""
-
-#: ports/stm/common-hal/audioio/AudioOut.c
-msgid "DMA init failed (right)"
-msgstr ""
-
 #: ports/atmel-samd/common-hal/paralleldisplaybus/ParallelBus.c
 #: ports/nordic/common-hal/paralleldisplaybus/ParallelBus.c
 msgid "Data 0 pin must be byte aligned"
@@ -2146,14 +2113,6 @@ msgstr ""
 msgid "System entry must be gnss.SatelliteSystem"
 msgstr ""
 
-#: ports/stm/common-hal/audioio/AudioOut.c
-msgid "TIM6 init failed"
-msgstr ""
-
-#: ports/stm/common-hal/audioio/AudioOut.c
-msgid "TIM6 master cfg failed"
-msgstr ""
-
 #: ports/stm/common-hal/microcontroller/Processor.c
 msgid "Temperature read timed out"
 msgstr ""

ports/stm/common-hal/audioio/AudioOut.c

@@ -339,12 +339,12 @@ void common_hal_audioio_audioout_construct(audioio_audioout_obj_t *self,
 
     // Only PA04 (DAC_CH1) is supported as left channel.
     if (left_channel != &pin_PA04) {
-        mp_raise_ValueError(MP_ERROR_TEXT("AudioOut requires pin A0 (PA04)"));
+        raise_ValueError_invalid_pin_name(MP_QSTR_left_channel);
     }
 
     // Right channel must be PA05 (DAC_CH2 / A1) if provided.
     if (right_channel != NULL && right_channel != &pin_PA05) {
-        mp_raise_ValueError(MP_ERROR_TEXT("AudioOut right channel requires pin A1 (PA05)"));
+        raise_ValueError_invalid_pin_name(MP_QSTR_right_channel);
     }
 
     // Claim pins first. The pin-claim system is what serialises this driver
@@ -393,7 +393,7 @@ void common_hal_audioio_audioout_construct(audioio_audioout_obj_t *self,
         __HAL_RCC_DAC_CLK_ENABLE();
         handle.Instance = DAC;
         if (HAL_DAC_Init(&handle) != HAL_OK) {
-            mp_raise_ValueError(MP_ERROR_TEXT("DAC init error"));
+            mp_raise_ValueError(MP_ERROR_TEXT("DAC Device Init Error"));
         }
     }
 
@@ -403,7 +403,7 @@ void common_hal_audioio_audioout_construct(audioio_audioout_obj_t *self,
     ch_cfg.DAC_Trigger = DAC_TRIGGER_NONE;
     ch_cfg.DAC_OutputBuffer = DAC_OUTPUTBUFFER_ENABLE;
     if (HAL_DAC_ConfigChannel(&handle, &ch_cfg, DAC_CHANNEL_1) != HAL_OK) {
-        mp_raise_ValueError(MP_ERROR_TEXT("DAC channel config error"));
+        mp_raise_ValueError(MP_ERROR_TEXT("DAC Channel Init Error"));
     }
 
     // Ramp DAC output up to quiescent value to prevent an audible pop.
@@ -447,9 +447,8 @@ void common_hal_audioio_audioout_deinit(audioio_audioout_obj_t *self) {
 
 void common_hal_audioio_audioout_play(audioio_audioout_obj_t *self,
     mp_obj_t sample, bool loop) {
-    if (common_hal_audioio_audioout_deinited(self)) {
-        mp_raise_ValueError(MP_ERROR_TEXT("AudioOut is deinited"));
-    }
+    // The shared-bindings layer guards every entry point with
+    // check_for_deinit, so a deinited self can't reach this function.
     common_hal_audioio_audioout_stop(self);
 
     // Extract sample format metadata via the canonical accessors so the
@@ -536,15 +535,15 @@ void common_hal_audioio_audioout_play(audioio_audioout_obj_t *self,
     tim6_handle.Init.ClockDivision = TIM_CLOCKDIVISION_DIV1;
     tim6_handle.Init.AutoReloadPreload = TIM_AUTORELOAD_PRELOAD_DISABLE;
     if (HAL_TIM_Base_Init(&tim6_handle) != HAL_OK) {
-        mp_raise_RuntimeError(MP_ERROR_TEXT("TIM6 init failed"));
+        mp_raise_RuntimeError_varg(MP_ERROR_TEXT("%q init failed"), MP_QSTR_TIM6);
     }
 
     // TRGO = Update event → triggers DAC conversion each period.
     TIM_MasterConfigTypeDef master_cfg = {0};
     master_cfg.MasterOutputTrigger = TIM_TRGO_UPDATE;
     master_cfg.MasterSlaveMode = TIM_MASTERSLAVEMODE_DISABLE;
     if (HAL_TIMEx_MasterConfigSynchronization(&tim6_handle, &master_cfg) != HAL_OK) {
-        mp_raise_RuntimeError(MP_ERROR_TEXT("TIM6 master cfg failed"));
+        mp_raise_RuntimeError_varg(MP_ERROR_TEXT("%q init failed"), MP_QSTR_TIM6);
     }
     // NOTE: ports/atmel-samd's audio_dma_setup_playback handles AUDIO_DMA_OK
     // and two specific error codes but lets any other non-OK return fall
@@ -582,7 +581,7 @@ void common_hal_audioio_audioout_play(audioio_audioout_obj_t *self,
     hdma->Init.Priority = DMA_PRIORITY_VERY_HIGH;
     hdma->Init.FIFOMode = DMA_FIFOMODE_DISABLE;
     if (HAL_DMA_Init(hdma) != HAL_OK) {
-        mp_raise_RuntimeError(MP_ERROR_TEXT("DMA init failed"));
+        mp_raise_RuntimeError_varg(MP_ERROR_TEXT("%q init failed"), MP_QSTR_DMA);
     }
     __HAL_LINKDMA(&handle, DMA_Handle1, *hdma);
 
@@ -605,7 +604,7 @@ void common_hal_audioio_audioout_play(audioio_audioout_obj_t *self,
         hdma_r->Init.Priority = DMA_PRIORITY_VERY_HIGH;
         hdma_r->Init.FIFOMode = DMA_FIFOMODE_DISABLE;
         if (HAL_DMA_Init(hdma_r) != HAL_OK) {
-            mp_raise_RuntimeError(MP_ERROR_TEXT("DMA init failed (right)"));
+            mp_raise_RuntimeError_varg(MP_ERROR_TEXT("%q init failed"), MP_QSTR_DMA);
         }
         __HAL_LINKDMA(&handle, DMA_Handle2, *hdma_r);
 
@@ -630,7 +629,7 @@ void common_hal_audioio_audioout_play(audioio_audioout_obj_t *self,
         }
         m_free(self->dma_buffer);
         self->dma_buffer = NULL;
-        mp_raise_RuntimeError(MP_ERROR_TEXT("DAC DMA start failed"));
+        mp_raise_RuntimeError_varg(MP_ERROR_TEXT("%q init failed"), MP_QSTR_DAC);
     }
 
     if (self->right_channel != NULL) {
@@ -646,7 +645,7 @@ void common_hal_audioio_audioout_play(audioio_audioout_obj_t *self,
             self->dma_buffer = NULL;
             m_free(self->dma_buffer_r);
             self->dma_buffer_r = NULL;
-            mp_raise_RuntimeError(MP_ERROR_TEXT("DAC DMA start failed (right channel)"));
+            mp_raise_RuntimeError_varg(MP_ERROR_TEXT("%q init failed"), MP_QSTR_DAC);
         }
     }