Added peripheral support for Daisy Seed stm32H750 board #10198
Merged
Conversation
snkYmkrct
changed the title
tannewt
requested changes
Mar 31, 2025
tannewt
left a comment
tannewt
left a comment
Member
There was a problem hiding this comment.
Thanks for continuing work on this! One bigish suggestion around the settings.
- Added the SDRAM controller and set up heap to use the 64 MB external RAM - Added the rest of the board pin definitions from the pinout - Did peripheral pins cleanup for the stm32H750 chip - Added SDMMC peripheral and sdioio module support - Added pwmio support and started work on audiopwmio
tannewt
requested changes
Apr 4, 2025
tannewt
left a comment
tannewt
left a comment
Member
There was a problem hiding this comment.
Much better! Two more minor things. Thanks!
| #include "sdram.h" | ||
|
|
||
| // Use the MP_WEAK supervisor/shared/board.c versions of routines not defined here. | ||
| extern void port_add_sdram_to_heap(void); |
Member
There was a problem hiding this comment.
Put this in a new supervisor/stm.h and rename to stm_add_sdram_to_heap. The port_ prefix is meant to be cross-port apis from supervisor/port.h.
active_audio was set to NULL, but then used in the following set_pin() call. because of MPU, this triggered hard fault on the stm32h7.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.