increase default PYSTACK size from 1536 to 2048#10236
Merged
Merged
Conversation
FoamyGuy
approved these changes
Apr 8, 2025
FoamyGuy
left a comment
FoamyGuy
left a comment
Collaborator
There was a problem hiding this comment.
I tested a build from this branch on PyPortal with the Cleveland art project and confirmed it is able to run with this version without having any stack size declared in settings.toml now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increase default CIRCUITPY_PYSTACK_SIZE from 1536 to 2048, except on SAMD21. This fixes pystack-exhausted errors for several PyPortal projects, and doesn't use up too much RAM.