Two enhancements for Fruit Jam launcher#10238
Conversation
1b5006a to
0ffa06a
Compare
RetiredWizard
left a comment
There was a problem hiding this comment.
It looks like you missed the second commit.
1. Set working directory for subsequent file. 2. Add `pathlib` for easy file discovery.
|
@RetiredWizard Thanks for the additional comments. I'll need to be better about testing my Claude generated code. I've fixed in a slightly different way by fixing the QSTRs. |
|
I was planning on giving pathlib a pretty thorough workout by incorporating into the PyDOS directory system. Currently I'm using a Python workaround for the vfsFat mount point issue (can't traverse up a path to the root #8409) and was hoping that I might see a way to put the workaround in the pathlib core code. I'll probably put that on the back burner now though 😁 |
|
I'm not sure how the stem/name/suffix methods will be used but there were some minor differences in the results of paths that contained '.' or '..' elements between this version and cpython. Other than that, I gave most of the methods at least a brief test and everything seems to be working. |
|
Dan and I chatted about this and he pointed out that I do still want to fix the os implementation of cwd because pathlib will build on it and there are existing bugs filed for it. |
|
I'm going to close this and split it into to PRs:
|
pathlibfor easy file discovery.