Fix RP2xxx I2SOut reversed channels#10250
Merged
Merged
Conversation
tannewt
requested changes
Apr 14, 2025
Member
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
One extra change and please add comments in the pio files that explain what the permutation is. Thanks!
Collaborator
Author
|
CI is weird, as of this moment, it has only done the doc build. |
Collaborator
Author
|
CI now OK. |
tannewt
requested changes
Apr 15, 2025
Member
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
Just a couple more comments to hopefully make it easier to maintain.
Collaborator
Author
|
@tannewt this is ready for review again. |
|
Thank you all! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The left and right stereo channels were reversed for most cases of
audiobusio.I2SOutonraspberrypi. See the table in #10230 (comment) for details.This was not a problem for
audiopwmio.PWMAudioOut, and not a problem for Espressif on SAMDI2SOut. The problem was that the data was in the opposite channel order expected. Interestingly, the sample programinFixed by flipping the LRCLK in three out of the four PIO programs. Also I put the PIO programs into separate files which are checked in, for convenience. They are not yet built automatically -- we could do that later.
Tested on a Metro RP2040 with an Adafruit Speaker Bonnet.
@VinceParsons FYI