Skip to content

Add support for Pimoroni Badger2350#10929

Open
bablokb wants to merge 3 commits intoadafruit:mainfrom
bablokb:badger2350
Open

Add support for Pimoroni Badger2350#10929
bablokb wants to merge 3 commits intoadafruit:mainfrom
bablokb:badger2350

Conversation

@bablokb
Copy link
Copy Markdown

@bablokb bablokb commented Apr 9, 2026

Board definition for Pimoroni Badger2350

Copy link
Copy Markdown
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small things. Thanks for the PR!

Comment on lines +126 to +128
// button-state on reset
{ MP_ROM_QSTR(MP_QSTR_RESET_STATE), (mp_obj_t)&get_reset_state_obj },
{ MP_ROM_QSTR(MP_QSTR_ON_RESET_PRESSED), (mp_obj_t)&on_reset_pressed_obj },
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this stuff for?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to capture button state before CircuitPython takes over. Instead of having to press a button for several seconds until user-space takes over, this is basically instantaneous. These two methods allow to query the state once user-space takes over.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please document these somewhere so folks can find how to use them.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any suggestions? I don't see any board specific documentation within the CircuitPython source tree for other boards yet so I don't feel this is a requirement. And I doubt casual users will look into such an obscure place as the source tree anyhow.

But I actually wonder why. There are so many very specialized boards supported by CP, and for all of those non-mainstream boards you just have to look up the exact information (e.g. schematic, source) if you want to make full use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants