audiowriter module#11106
Open
FoamyGuy wants to merge 5 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This new module provides an audio sink that writes to a file. Its API is essentially a drop in replacement in code for where you would normally use
AudioOutor one of the variations of it.This allows saving audio generated from synthio and/or effects chains.
All of my testing has been on Metro RP2350. There are perhaps more ports or devices that this could be enabled on, right now I kept it only to rpi port and esp32s2. I left out the rest of the esp devices because they had
audioiodisabled, but maybe it would make more sense to have this depend on synthio and/or the audio effects flag since this writer functionality could be used with those even on ports that do not have other options for audio out theoretically.